Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JMENano] Backport of #45167 (Add customize functions to recompute Puppi weights and PuppiMET, add new autoNano option) to 14_0_X #45176

Conversation

nurfikri89
Copy link
Contributor

Backport of #45167

Original PR description:

This PR adds three wrapper functions which

  • set the PuppiProducer instances (packedpuppi & packedpuppiNoLep) to recompute puppi weights.
  • setup the recalculation of PuppiMET.
  • wraps over the two functions above.

The three functions can be set up in cmsRun config files using --customise or -customize_commands arguments of cmsDriver.py. This would be useful if a (official or private) JMENano production needs updated Puppi weights. An autoNano option called jmeNANOrePuppi is added which sets up JMENano production with recomputation of Puppi weights and Puppi MET. Added two new test workflows (2500.319,2500.406) using the new autoNano option.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
passes the new JMENano wokflows runTheMatrix: runTheMatrix.py -i all --ibeos -l 2500.319,2500.406

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

A new Pull Request was created by @nurfikri89 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)

@sunilUIET, @subirsarkar, @vlimant, @srimanob, @AdrianoDee, @hqucms, @miquork, @cmsbuild, @ftorrresd can you please review it and eventually sign? Thanks.
@gpetruc, @fabiocos, @AnnikaStein, @Martin-Grunewald, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor

vlimant commented Jun 10, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Jun 10, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a953b4/39807/summary.html
COMMIT: bc28016
CMSSW: CMSSW_14_0_X_2024-06-09-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45176/39807/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.319-size.json
  • Nano ERROR: Missing ref/2500.319-size.json
  • Nano ERROR: Missing ref/2500.406-size.json
  • Nano ERROR: Missing ref/2500.406-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.783 | 2.783 | 0.000 ( +0.0% ) | 3.98 | 3.99 | -0.2% | 2.238 | 2.252 |
    | 2500.001 | 2.897 | 2.897 | 0.000 ( +0.0% ) | 3.57 | 3.59 | -0.7% | 2.672 | 2.585 |
    | 2500.002 | 2.843 | 2.843 | 0.000 ( +0.0% ) | 3.70 | 3.70 | -0.1% | 2.665 | 2.569 |
    | 2500.01 | 1.446 | 1.446 | 0.000 ( +0.0% ) | 7.05 | 6.95 | +1.4% | 2.357 | 2.339 |
    | 2500.011 | 1.906 | 1.906 | 0.000 ( +0.0% ) | 3.72 | 3.65 | +1.8% | 2.552 | 2.529 |
    | 2500.012 | 1.761 | 1.761 | 0.000 ( +0.0% ) | 5.47 | 5.42 | +0.9% | 2.464 | 2.337 |
    | 2500.1 | 2.354 | 2.354 | 0.000 ( +0.0% ) | 5.17 | 5.24 | -1.3% | 2.080 | 2.082 |
    | 2500.2 | 2.459 | 2.459 | 0.000 ( +0.0% ) | 5.94 | 5.99 | -0.8% | 1.993 | 1.997 |
    | 2500.21 | 1.286 | 1.286 | 0.000 ( +0.0% ) | 4.25 | 4.29 | -1.1% | 2.290 | 2.285 |
    | 2500.211 | 1.668 | 1.668 | 0.000 ( +0.0% ) | 3.91 | 3.94 | -0.7% | 2.355 | 2.358 |
    | 2500.3 | 2.229 | 2.229 | 0.000 ( +0.0% ) | 12.28 | 12.36 | -0.7% | 1.979 | 1.981 |
    | 2500.301 | 2.833 | 2.833 | 0.000 ( +0.0% ) | 10.94 | 10.43 | +5.0% | 1.963 | 1.965 |
    | 2500.31 | 1.348 | 1.348 | 0.000 ( +0.0% ) | 19.67 | 19.91 | -1.2% | 2.378 | 2.353 |
    | 2500.311 | 1.757 | 1.757 | 0.000 ( +0.0% ) | 15.66 | 15.80 | -0.9% | 2.463 | 2.437 |
    | 2500.312 | 7.164 | 7.164 | 0.000 ( +0.0% ) | 1.61 | 1.59 | +1.3% | 1.694 | 1.695 |
    | 2500.313 | 1.568 | 1.568 | 0.000 ( +0.0% ) | 9.31 | 9.08 | +2.6% | 1.047 | 1.050 |
    | 2500.314 | 1.236 | 1.236 | 0.000 ( +0.0% ) | 15.27 | 14.80 | +3.2% | 2.277 | 2.108 |
    | 2500.315 | 1.874 | 1.874 | 0.000 ( +0.0% ) | 15.28 | 15.48 | -1.3% | 2.346 | 2.339 |
    | 2500.316 | 3.342 | 3.342 | 0.000 ( +0.0% ) | 2.11 | 2.08 | +1.3% | 2.309 | 2.143 |
    | 2500.317 | 1.811 | 1.811 | 0.000 ( +0.0% ) | 14.77 | 15.22 | -2.9% | 2.165 | 2.294 |
    | 2500.318 | 4.136 | 4.136 | 0.000 ( +0.0% ) | 5.66 | 5.96 | -4.9% | 2.291 | 2.289 |
    | 2500.4 | 2.374 | 2.374 | 0.000 ( +0.0% ) | 11.78 | 11.89 | -0.9% | 1.814 | 1.905 |
    | 2500.401 | 1.885 | 1.885 | 0.000 ( +0.0% ) | 10.71 | 10.71 | +0.0% | 1.813 | 1.725 |
    | 2500.402 | 2.950 | 2.950 | 0.000 ( +0.0% ) | 10.50 | 10.68 | -1.7% | 1.741 | 1.729 |
    | 2500.403 | 5.474 | 5.474 | 0.000 ( +0.0% ) | 1.48 | 1.48 | -0.2% | 1.951 | 1.813 |
    | 2500.404 | 2.860 | 2.860 | 0.000 ( +0.0% ) | 10.63 | 10.67 | -0.4% | 1.746 | 1.756 |
    | 2500.405 | 8.700 | 8.700 | 0.000 ( +0.0% ) | 3.67 | 3.78 | -2.7% | 1.783 | 1.919 |
    | 2500.5 | 5.194 | 5.194 | 0.000 ( +0.0% ) | 16.25 | 16.55 | -1.8% | 1.506 | 1.659 |
    | 2500.51 | 9.120 | 9.120 | 0.000 ( +0.0% ) | 9.97 | 9.96 | +0.1% | 1.579 | 1.543 |

@cmsbuild
Copy link
Contributor

Pull request #45176 was updated. @hqucms, @kskovpen, @ftorrresd, @miquork, @AdrianoDee, @sunilUIET, @subirsarkar, @vlimant, @srimanob, @cmsbuild can you please check and sign again.

@vlimant
Copy link
Contributor

vlimant commented Jun 17, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a953b4/39912/summary.html
COMMIT: bd11cb5
CMSSW: CMSSW_14_0_X_2024-06-16-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45176/39912/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1997: CompilePython] Error 1
>> Plugins of all types refreshed.
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-06-16-2300'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1883: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-06-16-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Configuration/PyReleaseValidation


@nurfikri89
Copy link
Contributor Author

My apologies. It is a typo. I will fix this now.

@cmsbuild
Copy link
Contributor

Pull request #45176 was updated. @miquork, @ftorrresd, @hqucms, @cmsbuild, @kskovpen, @AdrianoDee, @subirsarkar, @sunilUIET, @vlimant, @srimanob can you please check and sign again.

@vlimant
Copy link
Contributor

vlimant commented Jun 17, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a953b4/39913/summary.html
COMMIT: 51f446b
CMSSW: CMSSW_14_0_X_2024-06-16-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45176/39913/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 65 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342426
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.319-size.json
  • Nano ERROR: Missing ref/2500.319-size.json
  • Nano ERROR: Missing ref/2500.406-size.json
  • Nano ERROR: Missing ref/2500.406-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.0 | 2.783 | 2.783 | 0.000 ( +0.0% ) | 3.94 | 3.91 | +0.8% | 2.149 | 2.098 |
    | 2500.001 | 2.897 | 2.897 | 0.000 ( +0.0% ) | 3.53 | 3.47 | +1.6% | 2.559 | 2.116 |
    | 2500.002 | 2.843 | 2.843 | 0.000 ( +0.0% ) | 3.67 | 3.66 | +0.3% | 2.547 | 2.126 |
    | 2500.01 | 1.446 | 1.446 | 0.000 ( +0.0% ) | 6.77 | 6.65 | +1.8% | 2.222 | 1.928 |
    | 2500.011 | 1.906 | 1.906 | 0.000 ( +0.0% ) | 3.62 | 3.58 | +1.1% | 2.371 | 1.994 |
    | 2500.012 | 1.761 | 1.761 | 0.000 ( +0.0% ) | 5.31 | 5.19 | +2.2% | 2.395 | 2.095 |
    | 2500.1 | 2.354 | 2.354 | 0.000 ( +0.0% ) | 5.13 | 5.07 | +1.3% | 1.988 | 2.060 |
    | 2500.2 | 2.459 | 2.459 | 0.000 ( +0.0% ) | 5.93 | 5.76 | +3.0% | 1.891 | 1.832 |
    | 2500.21 | 1.286 | 1.286 | 0.000 ( +0.0% ) | 4.21 | 4.17 | +1.0% | 2.192 | 1.970 |
    | 2500.211 | 1.668 | 1.668 | 0.000 ( +0.0% ) | 3.88 | 3.68 | +5.4% | 2.201 | 1.903 |
    | 2500.3 | 2.229 | 2.229 | 0.000 ( +0.0% ) | 12.02 | 11.37 | +5.8% | 1.983 | 1.958 |
    | 2500.301 | 2.833 | 2.833 | 0.000 ( +0.0% ) | 10.69 | 10.13 | +5.6% | 1.965 | 1.960 |
    | 2500.31 | 1.348 | 1.348 | 0.000 ( +0.0% ) | 19.41 | 18.29 | +6.1% | 2.376 | 2.387 |
    | 2500.311 | 1.757 | 1.757 | 0.000 ( +0.0% ) | 15.54 | 13.95 | +11.4% | 2.324 | 2.281 |
    | 2500.312 | 7.164 | 7.164 | 0.000 ( +0.0% ) | 1.57 | 1.50 | +4.6% | 1.691 | 1.695 |
    | 2500.313 | 1.568 | 1.568 | 0.000 ( +0.0% ) | 9.19 | 8.91 | +3.2% | 1.043 | 1.052 |
    | 2500.314 | 1.236 | 1.236 | 0.000 ( +0.0% ) | 14.57 | 13.45 | +8.3% | 2.236 | 1.693 |
    | 2500.315 | 1.874 | 1.874 | 0.000 ( +0.0% ) | 14.75 | 13.92 | +5.9% | 2.288 | 2.331 |
    | 2500.316 | 3.342 | 3.342 | 0.000 ( +0.0% ) | 2.10 | 2.01 | +4.6% | 1.888 | 2.184 |
    | 2500.317 | 1.811 | 1.811 | 0.000 ( +0.0% ) | 14.58 | 13.85 | +5.3% | 2.271 | 2.280 |
    | 2500.318 | 4.136 | 4.136 | 0.000 ( +0.0% ) | 5.69 | 5.57 | +2.2% | 2.309 | 2.287 |
    | 2500.4 | 2.374 | 2.374 | 0.000 ( +0.0% ) | 11.49 | 11.20 | +2.6% | 1.709 | 1.921 |
    | 2500.401 | 1.885 | 1.885 | 0.000 ( +0.0% ) | 10.68 | 9.93 | +7.6% | 1.535 | 1.687 |
    | 2500.402 | 2.950 | 2.950 | 0.000 ( +0.0% ) | 10.42 | 9.86 | +5.7% | 1.711 | 1.715 |
    | 2500.403 | 5.474 | 5.474 | 0.000 ( +0.0% ) | 1.47 | 1.40 | +4.8% | 1.964 | 1.765 |
    | 2500.404 | 2.860 | 2.860 | 0.000 ( +0.0% ) | 9.96 | 9.54 | +4.4% | 1.626 | 1.901 |
    | 2500.405 | 8.700 | 8.700 | 0.000 ( +0.0% ) | 3.60 | 3.52 | +2.4% | 1.269 | 1.894 |
    | 2500.5 | 5.194 | 5.194 | 0.000 ( +0.0% ) | 16.18 | 15.59 | +3.8% | 1.441 | 1.555 |
    | 2500.51 | 9.120 | 9.120 | 0.000 ( +0.0% ) | 9.92 | 9.67 | +2.7% | 1.583 | 1.607 |

@vlimant
Copy link
Contributor

vlimant commented Jun 18, 2024

+1
as for the master's PR #45167

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv
(plain backport)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5bd0684 into cms-sw:CMSSW_14_0_X Jun 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants