-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JMENano] Backport of #45167 (Add customize functions to recompute Puppi weights and PuppiMET, add new autoNano option) to 14_0_X #45176
Conversation
… PuppiMET. The functions can be used through cmsDriver customise commands.
…hts and Puppi MET.
…ith Puppi and PuppiMET recomputed.
A new Pull Request was created by @nurfikri89 for CMSSW_14_0_X. It involves the following packages:
@sunilUIET, @subirsarkar, @vlimant, @srimanob, @AdrianoDee, @hqucms, @miquork, @cmsbuild, @ftorrresd can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a953b4/39807/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
Pull request #45176 was updated. @hqucms, @kskovpen, @ftorrresd, @miquork, @AdrianoDee, @sunilUIET, @subirsarkar, @vlimant, @srimanob, @cmsbuild can you please check and sign again. |
please test |
-1 Failed Tests: Build BuildI found compilation error when building: gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1997: CompilePython] Error 1 >> Plugins of all types refreshed. gmake[1]: Target 'PostBuild' not remade because of errors. gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-06-16-2300' gmake: *** [config/SCRAM/GMake/Makefile.rules:1883: src] Error 2 gmake: Target 'all' not remade because of errors. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-06-16-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package Configuration/PyReleaseValidation |
My apologies. It is a typo. I will fix this now. |
Pull request #45176 was updated. @miquork, @ftorrresd, @hqucms, @cmsbuild, @kskovpen, @AdrianoDee, @subirsarkar, @sunilUIET, @vlimant, @srimanob can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a953b4/39913/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport of #45167
Original PR description:
This PR adds three wrapper functions which
packedpuppi
&packedpuppiNoLep
) to recompute puppi weights.The three functions can be set up in cmsRun config files using
--customise
or-customize_commands
arguments of cmsDriver.py. This would be useful if a (official or private) JMENano production needs updated Puppi weights. AnautoNano
option calledjmeNANOrePuppi
is added which sets up JMENano production with recomputation of Puppi weights and Puppi MET. Added two new test workflows (2500.319,2500.406
) using the newautoNano
option.PR validation:
passes the usual runTheMatrix test:
runTheMatrix.py -l limited -i all --ibeos
passes the new JMENano wokflows runTheMatrix:
runTheMatrix.py -i all --ibeos -l 2500.319,2500.406