Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Miscellaneous fixes for TRK POG Data/MC validation tool #45174

Merged
merged 3 commits into from
Jun 20, 2024
Merged

[14.0.X] Miscellaneous fixes for TRK POG Data/MC validation tool #45174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a97f012
fix MC Kshort sequence
mmusich Apr 17, 2024
69a5846
fix sign of cosPhi3D, make code more readable
mmusich Apr 17, 2024
0f4aa34
fix axis limis for trackPhiH to avoid using dynamic range which cause…
mmusich Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions DQM/TrackingMonitorSource/plugins/StandaloneTrackMonitor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1836,17 +1836,18 @@ void StandaloneTrackMonitor::analyze(edm::Event const& iEvent, edm::EventSetup c
theMainVtx = *theClosestVertex;
}
if (theMainVtx.isValid()) {
const math::XYZPoint theMainVtxPos(
theMainVtx.position().x(), theMainVtx.position().y(), theMainVtx.position().z());
const math::XYZPoint myVertex(
mumuTransientVtx.position().x(), mumuTransientVtx.position().y(), mumuTransientVtx.position().z());
const math::XYZPoint deltaVtx(
theMainVtxPos.x() - myVertex.x(), theMainVtxPos.y() - myVertex.y(), theMainVtxPos.z() - myVertex.z());
double cosphi3D =
(Zp.Px() * deltaVtx.x() + Zp.Py() * deltaVtx.y() + Zp.Pz() * deltaVtx.z()) /
(sqrt(Zp.Px() * Zp.Px() + Zp.Py() * Zp.Py() + Zp.Pz() * Zp.Pz()) *
sqrt(deltaVtx.x() * deltaVtx.x() + deltaVtx.y() * deltaVtx.y() + deltaVtx.z() * deltaVtx.z()));
cosPhi3DdileptonH_->Fill(cosphi3D, wfac);
const auto& mainVertexPos = theMainVtx.position();
const auto& myVertexPos = mumuTransientVtx.position();

const double deltaX = myVertexPos.x() - mainVertexPos.x();
const double deltaY = myVertexPos.y() - mainVertexPos.y();
const double deltaZ = myVertexPos.z() - mainVertexPos.z();

const double deltaNorm = sqrt(deltaX * deltaX + deltaY * deltaY + deltaZ * deltaZ);
const double zpNorm = sqrt(Zp.Px() * Zp.Px() + Zp.Py() * Zp.Py() + Zp.Pz() * Zp.Pz());

const double cosPhi3D = (Zp.Px() * deltaX + Zp.Py() * deltaY + Zp.Pz() * deltaZ) / (zpNorm * deltaNorm);
cosPhi3DdileptonH_->Fill(cosPhi3D, wfac);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion DQM/TrackingMonitorSource/python/StandaloneTrackMonitor_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
verbose = False,
trackEtaH = dict(Xbins = 60, Xmin = -3.0, Xmax = 3.0),
trackPtH = dict(Xbins = 100, Xmin = 0.0 ,Xmax = 100.0),
trackPhiH = dict(Xbins = 100, Xmin = 3.15, Xmax = 3.15),
trackPhiH = dict(Xbins = 100, Xmin = -3.15, Xmax = 3.15),
#trackMVAH = dict(Xbins = 100 ,Xmin = -1.0, Xmax = 1.0)
)
2 changes: 1 addition & 1 deletion DQM/TrackingMonitorSource/python/TrackingDataMCValidation_Standalone_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
* selectedPrimaryVertices
* KShortEventSelector
* KshortTracks
* standaloneTrackMonitorK0
* standaloneTrackMonitorK0MC
* KshortMonitor)

standaloneValidationLambdas = cms.Sequence(
Expand Down