Miscellaneous fixes for TRK POG Data/MC validation tool

[mmusich]

PR description:

Few miscellaneous fixes for the TRK POG data/MC validation tool:

• 6ca6c26: fix MC KShort analysis sequence
• 5e9ff21: fix sign of 3D pointing angle variable, make code slightly more readable
• e5a0fb2: fix axis limits for the trackPhiH ME to avoid using dynamic range which causes histogram merging issues

These were spotted by operating the data/MC validation tool on 2024 data.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, will be backported to CMSSW_14_0_X for 2024 data-taking purposes.

Cc: @dbruschi

[cmsbuild]

cms-bot internal usage

[mmusich]

type bug-fix

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45173/40529

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DQM/TrackingMonitorSource (dqm)

@syuvivida, @rvenditti, @nothingface0, @antoniovagnerini, @tjavaid can you please review it and eventually sign? Thanks.
@mtosi, @arossi83, @mmusich, @threus, @VourMa, @VinInn, @JanFSchulte, @jandrea, @idebruyn, @fioriNTU, @sroychow this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45173/40530

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #45173 was updated. @tjavaid, @nothingface0, @rvenditti, @syuvivida, @cmsbuild, @antoniovagnerini can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7be21b/39798/summary.html
COMMIT: e5a0fb2
CMSSW: CMSSW_14_1_X_2024-06-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45173/39798/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3445482
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3445459
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1