Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Modifications to L1REPACK:FullSimTP to prevent crashes and make it more compatible with other REPACK options #45170

Merged

Conversation

eyigitba
Copy link
Contributor

@eyigitba eyigitba commented Jun 7, 2024

PR description:

This PR started as a modification to L1REPACK:FullSimTP to prevent a crash due to missing GEM unpacker. However, while going through the config I realized some outdated options which I ended up removing. This config was already modifed to work only with L1T Stage-2 options, so there was no reason to keep around CSCTF/DTTF options.

Furthermore, I am changing the config for now to use unpacked muon TF inputs instead of calling muon TP re-emulation modules. This is mostly done to bypass a problem I observe in DT TP re-emulation that causes lower rates. I kept the muon TP re-emulation options in place to allow people to switch quickly between the two options.

PR validation:

I validated by running L1REPACK:uGT and L1REPACK:FullSimTP and comparing them. There are no crashes and the final rates are comparable up to re-emulation level mismatches.

The normal CMSSW workflows are probably no enough to check this PR, otherwise the crash would have been caught before.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45132

FYI @missirol

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

A new Pull Request was created by @eyigitba for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@davidlange6, @antoniovilela, @rappoccio, @fabiocos, @cmsbuild can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @felicepantaleo, @makortel, @fabiocos, @mtosi, @VinInn, @rovere, @VourMa, @Martin-Grunewald, @sameasy, @missirol, @slomeo, @mmusich, @dgulhan, @JanFSchulte this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2d14e/39808/summary.html
COMMIT: 65e01a6
CMSSW: CMSSW_14_0_X_2024-06-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45170/39808/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 27c652a into cms-sw:CMSSW_14_0_X Jun 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants