Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (8/N) #45161

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 6, 2024

backport of #45160

PR description:

Development of HLT menus for CMSSW_14_0_X.

  • This is the PR for the 14.0.X branch (this is the release cycle currently used for Run-3 HLT-menu development).
  • This version of the GRun HLT menu corresponds to the list of updates to the "V1.3" menu for the 2024 pp data-taking period.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3189 : [AlCa,ECAL,GEM,RPC] Replace L1uGT digis with RAW data in ALCAP0, ALCAPHISYM and RPCMON streams
  • CMSHLT-3195 : [CSC,GEM,RPC]Add GEM Trigger Information to RPCMON output
  • CMSHLT-3197 : [MUO] New BDT Model in Muon Doublet-Recovery
  • CMSHLT-3210 : [TSG] Add HLT_Physics_v to online special menus
  • CMSHLT-3211 : [SUS] Control trigger prescale tuning MSSM Hbb
  • CMSHLT-3212 : [TSG,Scouting] Adding 2024 upt L1 seeds to the DoubleMuon Scouting path
  • CMSHLT-3213 : [EGM,EXO,SMP] Add DST_PFScouting_SinglePhotonEB_v1 to the HLT menu
  • CMSHLT-3215 : [TAU,HIG] Remove HPS sequence from PNet ETau paths
  • CMSHLT-3219 : [BPH] single muon low pT paths for lumi-decay
  • CMSHLT-3225 : [TSG] Remove PS columns "1p8E34+X"
  • CMSHLT-3226 : [TSG] Remove PS column "2p0E34_NoMuShower"
  • CMSHLT-3227 : [PF,HIon] Update HIDQMGPUvsCPU EventContent with hltParticleFlowClusterHCAL* products
  • CMSHLT-3228 : [TSG] Set PS=1 for HLT-Scouting in "2p0E34_OnlyMuons"
  • CMSHLT-3229 : [TSG] Remove PS columns "2p0E34+ZeroBias" and "2p0E34+HLTPhysics" from the offline menu
  • CMSHLT-3233 : [TSG] Backport of some online updates from last PPS menus
  • CMSHLT-3234 : [TSG,DQM] Set PS=30 for Dataset_OnlineMonitor
  • CMSHLT-3235 : [TSG] Reassign hltFEDSelectorTCDS from HLTriggerFinalPath to those paths in streams actually saving its product

In addition, the following changes are included:

  • bc1aeea : fix bugs in hltPathOwners.json
  • a67fd2d : update the list of HLT path owners: menu 2024 V1.3
  • e5c104d : Introduce 2024v1.3 frozen menu and remove 2024v1.2

PR validation:

TSG Integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #45160 to the 2024 production cycle (CMSSW_14_0_X)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@rchatter, @fabiocos, @Martin-Grunewald, @thomreis, @missirol, @argiro, @wang0jin, @ReyerBand, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2024

type hlt-integration

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

Pull request #45161 was updated. @mmusich, @cmsbuild, @Martin-Grunewald can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0086/39761/summary.html
COMMIT: de5cdc8
CMSSW: CMSSW_14_0_X_2024-06-06-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45161/39761/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 71 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3328523
  • DQMHistoTests: Total failures: 483
  • DQMHistoTests: Total nulls: 62
  • DQMHistoTests: Total successes: 3327958
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 85.87599999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 18.523 KiB HLT/Muon
  • DQMHistoSizes: changed ( 12834.0,... ): -14.385 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12834.0,... ): 4.862 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -6.762 KiB HLT/TAU
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 7 / 46 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 585
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39155
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

Pull request #45161 was updated. @Martin-Grunewald, @mmusich, @cmsbuild can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

Pull request #45161 was updated. @mmusich, @Martin-Grunewald, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2024

unhold

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0086/39791/summary.html
COMMIT: a5d719c
CMSSW: CMSSW_14_0_X_2024-06-07-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45161/39791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 178 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3328523
  • DQMHistoTests: Total failures: 3204
  • DQMHistoTests: Total nulls: 62
  • DQMHistoTests: Total successes: 3325237
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 85.87599999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 18.523 KiB HLT/Muon
  • DQMHistoSizes: changed ( 12834.0,... ): -14.385 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12834.0,... ): 4.862 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -6.762 KiB HLT/TAU
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 7 / 46 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 503
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39237
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jun 11, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Jun 12, 2024

@cms-sw/orp-l2 can you please merge this?

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c339c61 into cms-sw:CMSSW_14_0_X Jun 12, 2024
13 checks passed
@mmusich mmusich deleted the HLTdevelopment140X branch June 12, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants