Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Updates to TkAlV0sAnalyzer and V0Monitor #45149

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 5, 2024

backport of #45056

PR description:

This PR updates TkAlV0sAnalyzer: an analyzer that was introduced in #43757 to monitor a new ALCARECO data-tier called TkAlV0s which contains the tracks and associated clusters, etc. from $K^0_s$→ππ and Λ→pπ decays. In order to test the analyzer the unit test Miscellanea is updated.
In the process I provide into 2566f9d some basic improvement to the existing V0 monitoring DQM module V0Monitor, mostly a fillDescriptions method.

PR validation:

scram b runtests_Miscellanea runs fine with this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45056 to CMSSW_14_0_X for data-taking purposes.

mmusich added 3 commits June 5, 2024 22:11
- added fillDescriptions
- const correctness member in initializer list
- correct inclusion guards as per coding rule 4.1
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • DQM/TrackingMonitor (dqm)

@syuvivida, @rvenditti, @saumyaphor4252, @consuegs, @nothingface0, @cmsbuild, @antoniovagnerini, @tjavaid, @perrotta can you please review it and eventually sign? Thanks.
@fioriNTU, @tlampen, @tocheng, @arossi83, @jandrea, @mmusich, @yuanchao, @threus, @VourMa, @idebruyn, @mtosi, @rsreds, @adewit, @JanFSchulte, @VinInn, @sroychow this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8264e/39727/summary.html
COMMIT: 3f1e500
CMSSW: CMSSW_14_0_X_2024-06-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45149/39727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2024

+alca

@tjavaid
Copy link

tjavaid commented Jun 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 84a79c0 into cms-sw:CMSSW_14_0_X Jun 7, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_TkAlV0sAnalyzerUpdates_14_0_X branch June 14, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants