Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2TauTagNNProducerAlpaka: do not call TF inference with empty grid #45147

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 5, 2024

PR description:

Fix for #45136.
Implemented in the same style as #44455 (originally from @valsdav).
When this input is passed to a TF model executed on a CPU without AVX512F AVX512_VNNI, the model is executed and returns an empty output without complaining. When AVX512F AVX512_VNNI instructions are present, the TF executor complains.

This PR avoids calling the TF inference if empty inputs are detected.

PR validation:

Run the HLT over all the error stream files from run-381543 and run-381544 following #45136 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported for data-taking purposes to CMSSW_14_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 5, 2024

type tau,bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jun 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45147/40489

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • RecoTauTag/HLTProducers (hlt)

@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@azotz, @silviodonato, @missirol, @mbluj this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc418c/39726/summary.html
COMMIT: 322acb9
CMSSW: CMSSW_14_1_X_2024-06-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45147/39726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338836
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

type hlt-int

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a91b3f7 into cms-sw:master Jun 6, 2024
11 checks passed
@mmusich mmusich deleted the mm_fix_protect_L2TauTagNNProducerAlpaka_empty_inputs branch June 14, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants