-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2TauTagNNProducerAlpaka
: do not call TF inference with empty grid
#45147
L2TauTagNNProducerAlpaka
: do not call TF inference with empty grid
#45147
Conversation
cms-bot internal usage |
type tau,bug-fix |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45147/40489
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc418c/39726/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
type hlt-int |
+1 |
PR description:
Fix for #45136.
Implemented in the same style as #44455 (originally from @valsdav).
When this input is passed to a TF model executed on a CPU without
AVX512F AVX512_VNNI
, the model is executed and returns an empty output without complaining. WhenAVX512F AVX512_VNNI
instructions are present, the TF executor complains.This PR avoids calling the TF inference if empty inputs are detected.
PR validation:
Run the HLT over all the error stream files from run-381543 and run-381544 following #45136 (comment).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported for data-taking purposes to CMSSW_14_0_X.