Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Introduce edm::Async service, and use it in CUDA and Alpaka modules #45143

Merged
merged 8 commits into from
Jun 24, 2024
Prev Previous commit
Next Next commit
Mark ReusableObjectHolder destructor as noexcept
Pretty much only piece that could throw is the destructor of T, and
bad things would happen if the while loop would terminate early, so we
could just call std::terminate() in case of an exception.
makortel committed Jun 5, 2024
commit f12db621aad974fbe36e5c60eb6163b8f3020d99
2 changes: 1 addition & 1 deletion FWCore/Utilities/interface/ReusableObjectHolder.h
Original file line number Diff line number Diff line change
@@ -88,7 +88,7 @@ namespace edm {
: m_availableQueue(std::move(iOther.m_availableQueue)), m_outstandingObjects(0) {
assert(0 == iOther.m_outstandingObjects);
}
~ReusableObjectHolder() {
~ReusableObjectHolder() noexcept {
assert(0 == m_outstandingObjects);
std::unique_ptr<T, Deleter> item;
while (m_availableQueue.try_pop(item)) {