-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_0_X] Introduce edm::Async service, and use it in CUDA and Alpaka modules #45143
Conversation
Pretty much only piece that could throw is the destructor of T, and bad things would happen if the while loop would terminate early, so we could just call std::terminate() in case of an exception.
A new Pull Request was created by @makortel for CMSSW_14_0_X. It involves the following packages:
@Dr15Jones, @smuzaffar, @makortel, @fwyzard, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
enable gpu |
@cmsbuild, please test |
-1 Failed Tests: GpuUnitTests GPU Unit TestsI found 1 errors in the following unit tests: ---> test testTFVisibleDevicesCUDA had ERRORS Comparison SummarySummary:
GPU Comparison SummarySummary:
|
The test failure is
|
please test with #44375 |
+heterogeneous |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fe5da/39986/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
@smuzaffar could you sign this backport ? |
@fwyzard , @Dr15Jones is back from vacations and I hope he will review this |
+1 seems to have all the changes to the PR done in 14_1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #44901. Tests done by @fwyzard in #44901 (comment) showed this way of synchronizing host and NVIDIA GPU would improve HLT throughput by about 1.5 % ± 0.3 %.
PR validation:
None beyond #44901
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44901