Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Add context for exceptions being thrown via RootOutputFile::finishEndFile() #45142

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 5, 2024

PR description:

Backport of #45141 . Adds context information to exception shown in #45089 (comment) .

PR validation:

See #45141

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45141

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

A new Pull Request was created by @makortel for CMSSW_14_0_X.

It involves the following packages:

  • IOPool/Output (core)

@cmsbuild, @makortel, @Dr15Jones, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

makortel commented Jun 5, 2024

@cmsbuild, please test

@makortel
Copy link
Contributor Author

makortel commented Jun 5, 2024

backport of #45141

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a27a34/39714/summary.html
COMMIT: 809f850
CMSSW: CMSSW_14_0_X_2024-06-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45142/39714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 100 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338683
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d9d953d into cms-sw:CMSSW_14_0_X Jun 13, 2024
10 checks passed
@makortel makortel deleted the finishEndFileException_140x branch July 10, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants