-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update btag from DeepCSV to ParticleNet for BTV DQM #45077
Update btag from DeepCSV to ParticleNet for BTV DQM #45077
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45077/40393
|
A new Pull Request was created by @yeonsu108 for master. It involves the following packages:
@tjavaid, @syuvivida, @antoniovagnerini, @rvenditti, @cmsbuild, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133b6/39590/summary.html Comparison SummarySummary:
|
looks like this PR triggers a lot of additional warnings, e.g.:
|
The warning is understood, and it is an expected situation. We are not interested in the events. If a lot of warning messages are a problem, we can turn it off. What do you think? In the meantime, the shallowTagInfo is outdated, will be updated in the next PR (not this one) |
I think leaving lots of warnings active is not a good policy (will contribute in filling logs and warning streams, see also #41456). Turning it off is an option, but wouldn't it be better to fix it at the origin? |
Thanks for insight, I create a commit to turn off the warning |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45077/40416
|
Pull request #45077 was updated. @cmsbuild, @nothingface0, @antoniovagnerini, @rvenditti, @tjavaid, @syuvivida can you please check and sign again. |
please, test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133b6/39712/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR aims to
PR validation:
This PR passes the basic test procedure suggested in the CMSSW PR instructions
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it should be backported to CMSSW_14_0_X