[14_0_X] Protect against invalid trajectory state on surface in STA muon reco

[mandrenguyen]

backport of #45049

[cmsbuild]

A new Pull Request was created by @mandrenguyen for CMSSW_14_0_X.

It involves the following packages:

• RecoMuon/StandAloneTrackFinder (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@HuguesBrun, @andrea21z, @Fedespring, @CeliaFernandez, @rociovilar, @jhgoh, @abbiendi, @cericeci, @missirol, @JanFSchulte, @trocino, @bellan this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Protect against invalid trajectory state on surface in STA muon reco #45049

[cmsbuild]

cms-bot internal usage

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-283f0f/39534/summary.html
COMMIT: addd479
CMSSW: CMSSW_14_0_X_2024-05-26-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45050/39534/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 59 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3333953
• DQMHistoTests: Total failures: 1196
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3332737
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

urgent

• addressing a crash observed in Tier0

Francesco as ORM

[francescobrivio]

hold

• this fix isn't complete as it solves one of the crashes reported, but not all of them: see details in Segmentation violation for StandAloneMuonProducer in CMSSW_14_0_7 #45035 (comment)

[cmsbuild]

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

hold

what's the purpose of the hold? this still fixes something, no?

[francescobrivio]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1