Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] PhotonXGBoostEstimator : set XGBoost to use one thread to avoid spawning hundreds of OpenMP threads #45043

Merged
merged 1 commit into from
May 27, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 25, 2024

backport of #45042

PR description:

Title says it all, see #44923 for details

PR validation:

Run the script #44923 (comment) and verified with gdb and info threads that the amount of threads is limited, see also #44923 (comment) and #44923 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45042 in the 2024 production cycle for data-taking purposes.

@mmusich
Copy link
Contributor Author

mmusich commented May 25, 2024

type egamma, bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • RecoEgamma/PhotonIdentification (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@sameasy, @jainshilpi, @Prasant1993, @ram1123, @missirol, @afiqaize, @a-kapoor, @varuns23, @Sam-Harper, @lgray, @sobhatta, @valsdav this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 25, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19306a/39523/summary.html
COMMIT: f537906
CMSSW: CMSSW_14_0_X_2024-05-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45043/39523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

urgent

  • needed for a patch at HLT for data-taking

@francescobrivio
Copy link
Contributor

type hlt-integration

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6d3618e into cms-sw:CMSSW_14_0_X May 27, 2024
10 checks passed
@mmusich mmusich deleted the mm_fix_44923_in_14_0_X branch May 27, 2024 18:08
smuzaffar pushed a commit that referenced this pull request May 27, 2024
[14.0.X] `PhotonXGBoostEstimator` : set `XGBoost` to use one thread to avoid spawning hundreds of OpenMP threads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants