Phase2-hgx356 Fix the bugs in HGCal TB simulation for 2023 scenarios

[bsunanda]

PR description:

Fix the bugs in HGCal TB simulation for 2023 scenarios

PR validation:

Tested using the configuration files in SImG4CMS/HGCalTestBeam

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45036/40334

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/HGCalTBCommonData (geometry)
• SimG4CMS/HGCalTestBeam (upgrade, simulation)

@makortel, @mdhildreth, @Dr15Jones, @bsunanda, @civanch, @subirsarkar, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-531457/39508/summary.html
COMMIT: 300613c
CMSSW: CMSSW_14_1_X_2024-05-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45036/39508/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[bsunanda]

type bugfix

[bsunanda]

Type BugFix

[bsunanda]

+geometry

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1