-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled ROCs for Online DQM Pixel Summary #45026
Disabled ROCs for Online DQM Pixel Summary #45026
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45026/40319
|
A new Pull Request was created by @alaperto for master. It involves the following packages:
@rvenditti, @antoniovagnerini, @cmsbuild, @tjavaid, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33094a/39492/summary.html Comparison SummarySummary:
|
@@ -272,6 +272,7 @@ void SiPixelPhase1Summary::fillSummaries(DQMStore::IBooker& iBooker, DQMStore::I | |||
//Fill the dead ROC summary | |||
std::vector<trendPlots> trendOrder = {layer1, layer2, layer3, layer4, ring1, ring2}; | |||
std::vector<int> nRocsPerTrend = {1536, 3584, 5632, 8192, 4224, 6528}; | |||
std::vector<int> nDisabledRocs = {12, 128, 240, 320, 96, 120}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. It's good to know that the list is stable and that the numbers have been consistent since June 2023. Let's hope that the detector remains stable and we don't encounter further losses in 2024 and 2025.
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Exclude disabled ROCs when calculating the fraction of "good" ROCs for the Online DQM Pixel Summary map.
PR validation:
Data produced with cmsRun on recent 2024 pp run 380400:
cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024D-v1/RAW runNumber=380400
Results available in private GUI
About backport
This PR is intended for 2024 data taking. There will be a backport to 14_0_X in a separate PR.