Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled ROCs for Online DQM Pixel Summary #45026

Merged
merged 1 commit into from
May 26, 2024

Conversation

alaperto
Copy link
Contributor

Exclude disabled ROCs when calculating the fraction of "good" ROCs for the Online DQM Pixel Summary map.

PR validation:

Data produced with cmsRun on recent 2024 pp run 380400:

cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024D-v1/RAW runNumber=380400

Results available in private GUI

About backport

This PR is intended for 2024 data taking. There will be a backport to 14_0_X in a separate PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45026/40319

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alaperto for master.

It involves the following packages:

  • DQM/SiPixelPhase1Summary (dqm)

@rvenditti, @antoniovagnerini, @cmsbuild, @tjavaid, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks.
@arossi83, @mmusich, @idebruyn, @threus, @sroychow, @jandrea, @fioriNTU this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@sroychow
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33094a/39492/summary.html
COMMIT: 08b87be
CMSSW: CMSSW_14_1_X_2024-05-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45026/39492/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 31
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338811
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@@ -272,6 +272,7 @@ void SiPixelPhase1Summary::fillSummaries(DQMStore::IBooker& iBooker, DQMStore::I
//Fill the dead ROC summary
std::vector<trendPlots> trendOrder = {layer1, layer2, layer3, layer4, ring1, ring2};
std::vector<int> nRocsPerTrend = {1536, 3584, 5632, 8192, 4224, 6528};
std::vector<int> nDisabledRocs = {12, 128, 240, 320, 96, 120};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. It's good to know that the list is stable and that the numbers have been consistent since June 2023. Let's hope that the detector remains stable and we don't encounter further losses in 2024 and 2025.

@tjavaid
Copy link

tjavaid commented May 24, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants