-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-alca247Y Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs #45010
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40292
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40293 |
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ad46/39455/summary.html Comparison SummarySummary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion below is just to make the config safer from possible typing errors.
In any case, I'd suggest to squeeze the commits, in order to get rid of the file remained with invalid state in the history.
process.towerMakerAll.hbheInput = cms.InputTag("hbhereco") | ||
process.towerMakerAll.hoInput = cms.InputTag("none") | ||
process.towerMakerAll.hfInput = cms.InputTag("none") | ||
process.towerMakerAll.ecalInputs = cms.VInputTag(cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE")) | ||
process.towerMakerAll.AllowMissingInputs = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.towerMakerAll.hbheInput = cms.InputTag("hbhereco") | |
process.towerMakerAll.hoInput = cms.InputTag("none") | |
process.towerMakerAll.hfInput = cms.InputTag("none") | |
process.towerMakerAll.ecalInputs = cms.VInputTag(cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE")) | |
process.towerMakerAll.AllowMissingInputs = True | |
process.towerMakerAll.hbheInput = "hbhereco" | |
process.towerMakerAll.hoInput = "none" | |
process.towerMakerAll.hfInput = "none" | |
process.towerMakerAll.ecalInputs = [cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE")] | |
process.towerMakerAll.AllowMissingInputs = True |
or even (including only what modified wrt the original calotowermaker
)
process.towerMakerAll.hbheInput = cms.InputTag("hbhereco") | |
process.towerMakerAll.hoInput = cms.InputTag("none") | |
process.towerMakerAll.hfInput = cms.InputTag("none") | |
process.towerMakerAll.ecalInputs = cms.VInputTag(cms.InputTag("ecalRecHit","EcalRecHitsEB"), cms.InputTag("ecalRecHit","EcalRecHitsEE")) | |
process.towerMakerAll.AllowMissingInputs = True | |
process.towerMakerAll.hoInput = "none" | |
process.towerMakerAll.hfInput = "none" | |
process.towerMakerAll.AllowMissingInputs = True |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40304 |
- Can now use tuples to set parameters that take multiple values - Improved validation of values passed to V* parameters
- denote if must use full type info when dumping to cfi - test module now makes explicit named cfi files compatible with default
…os/macros/jobs (restore the material from cms-sw#45010)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45010/40349
|
Pull request #45010 was updated. @cmsbuild, @saumyaphor4252, @consuegs, @mandrenguyen, @Dr15Jones, @smuzaffar, @jfernan2, @perrotta, @makortel can you please check and sign again. |
Destroyed the PR by attempting squashing. A new PR is made in #45045 |
Run3-alca247YX Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs (restore the material from #45010)
PR description:
Add examples for the IsoTrack calibration in Calibration/HcalCalibAlgos/macros/jobs
PR validation:
Used these files in getting calibration constants for 2024 IsoTrack studies
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
nothing special