Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop dz from being NaN in PackedCandidates #45009

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

swagata87
Copy link
Contributor

PR description:

Aiming to fix the issue reported and discussed in #44976

PR validation:

AOD->miniAOD step runs fine and dz is not NaN anymore. Tested with DYto2TautoMuTauh events.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45009/40290

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 for master.

It involves the following packages:

  • DataFormats/PatCandidates (xpog, reconstruction)

@mandrenguyen, @jfernan2, @hqucms, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@hatakeyamak, @missirol, @gouskos, @gpetruc, @rovere this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor Author

type pf

@cmsbuild cmsbuild added the pf label May 21, 2024
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f78518/39450/summary.html
COMMIT: 81b1b2f
CMSSW: CMSSW_14_1_X_2024-05-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45009/39450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 851
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3337991
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

solves #44976

@jfernan2
Copy link
Contributor

+1

@hqucms
Copy link
Contributor

hqucms commented May 22, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 94de9c6 into cms-sw:master May 22, 2024
11 checks passed
@swagata87 swagata87 deleted the dznanfix branch May 22, 2024 18:02
@swagata87 swagata87 restored the dznanfix branch May 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants