Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Adding PNET scores to offline HLT DQM #45003

Merged
merged 4 commits into from
May 28, 2024

Conversation

aniketkhanal
Copy link
Contributor

This is a backport of #44754 and #44926 (the latter fixes some relval issues created by #44754 ). We are backporting these changes for the current data taking.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aniketkhanal for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@cmsbuild, @antoniovagnerini, @rvenditti, @nothingface0, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@cericeci, @HuguesBrun, @mtosi, @jhgoh, @trocino, @missirol, @Fedespring, @rociovilar this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 20, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented May 21, 2024

test parameters:

  • workflow = 142.0

@mmusich
Copy link
Contributor

mmusich commented May 21, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dd506/39437/summary.html
COMMIT: 819dd1c
CMSSW: CMSSW_14_0_X_2024-05-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45003/39437/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391392
  • DQMHistoTests: Total failures: 407
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3390965
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6931.257 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 1035.999 KiB HLT/BTV
  • DQMHistoSizes: changed ( 141.042,... ): 929.087 KiB HLT/BTV
  • Checked 206 log files, 168 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented May 24, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants