Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Improvements for Tracker Alignment DiMuonValidation #45002

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 20, 2024

backport of #44994

PR description:

The goal of this PR is to inject in release few improvements for Tracker Alignment DiMuonValidation setup.
These are:

  • adding 3D histograms of di-muon mass vs η, φ for derivation of 2D bias maps: 921e90b
  • improve the titles of some of the monitoring histograms in bins of muon pseudo-rapidity: e5ce8ed, b7bf76b
  • finally, introduce a new C++ macro to perform fits of the mass bias in bins of track η, φ (commits 50a8396, 3e6604d, 4202a56).
    This is foreseen in the longer term to replace the existing Zmumumerge.cc class which is currently used by the so-called "all-in-one" tool. The new plotting script fixes several issues with the final plotting currently provided by the all-in-one; however, the replacement is not done in this PR and will have to be done at a second time.

PR validation:

Private validation was carried out using this branch and operating the new plotting macros.
The plots at this link were obtained. For a comparison with the output of the current code, see please here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44994 to the 2024 data-taking release cycle.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 20, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@consuegs, @saumyaphor4252, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@rsreds, @adewit, @tlampen, @tocheng, @yuanchao, @mmusich this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 20, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 20, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6c973/39435/summary.html
COMMIT: 4202a56
CMSSW: CMSSW_14_0_X_2024-05-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45002/39435/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5ffef55 into cms-sw:CMSSW_14_0_X May 22, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_improve_DiMuonValidation_14_0_X branch May 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants