Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Adding PPS and ECALTiming Runs to HLT Menu veto of PCL alignment #44993

Conversation

phnattla
Copy link
Contributor

Backport of PR #44983 to CMSSW 14_0_X

PR description:

Added the "special" HLT menus PPS and ECALTiming to the veto_HLT_Menu for the PCL alignment, so that such runs are not used in the PCL alignment.

PR validation:

PR was validated by testing the MilleStep for a PPS run (Run 379060) and a ECALTiming run (Run 379354), using the following command:

cmsDriver.py milleStep -s ALCA:PromptCalibProdSiPixelAli --conditions 140X_dataRun3_Express_v2 --scenario pp --data --era Run3 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100 --dasquery='file dataset=/StreamExpress/Run2024B-TkAlMinBias-Express-v1/ALCARECO run=<379060, 379354>'

@mmusich @dmeuser @henriettepetersen @TomasKello

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2024

A new Pull Request was created by @phnattla for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@cmsbuild, @saumyaphor4252, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @tlampen, @yuanchao, @pakhotin, @rsreds, @mmusich, @tocheng this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

test parameters:

  • workflows = 1001.0, 1001.2, 1001.3, 1001.4, 1002.3

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

backport of #44983

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-893a69/39420/summary.html
COMMIT: 94cc2e1
CMSSW: CMSSW_14_0_X_2024-05-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44993/39420/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 89 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3363945
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3363916
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 223 log files, 169 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Master version of this PR had been just merged
  • Given the content, there is no need to wait for the IB tests to sign also this backport

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@cms-sw/orp-l2 please consider merging this PR as it will be needed for data-taking (not urgently).

Cheers,
Francesco as ORM

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac47892 into cms-sw:CMSSW_14_0_X May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants