-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RelMon Piecharts using Chart.js
#44977
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40258
|
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@rvenditti, @tjavaid, @nothingface0, @syuvivida, @antoniovagnerini, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@AdrianoDee Very nice! You also beat me to it, we were thinking with Geovanny alternatives yesterday and chart.js was a good one. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40261
|
Pull request #44977 was updated. @syuvivida, @cmsbuild, @tjavaid, @antoniovagnerini, @rvenditti, @nothingface0 can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40262
|
Pull request #44977 was updated. @syuvivida, @cmsbuild, @rvenditti, @antoniovagnerini, @tjavaid, @nothingface0 can you please check and sign again. |
Co-authored-by: Dimitris Papagiannis <[email protected]>
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40523
|
Pull request #44977 was updated. @tjavaid, @syuvivida, @rvenditti, @antoniovagnerini, @nothingface0 can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e7831/39784/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 any comment left? |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
@tjavaid If needed yes, let me know. For us (PdmV) we are fine with 14_1_X |
Hi @AdrianoDee , I think it is good to have it also in |
+1 |
PR description:
This PR proposes a solution to the decommissioning of chart.googleapis.com used for RelMon reports, as discussed in #44711 and #44969. Basically it replaces the google api with a js script relying on
Chart.js
. I'm not an expert so there may be better solutions but it seems to work.Before integrating it I would allow/ask PdmV developers to test it in a dev instance to see everything works (@ggonzr). I imagine also DQM people would like to test this (@cms-sw/dqm-l2, @nothingface0).
Some further changes done to fix the gauge plots and to make the table more readable and scrollable. See e.g. https://cms-pdmv-prod.web.cern.ch/relmon/1715742438___CMSSW_14_1_0_pre3_Phase2_2026D110vsCMSSW_14_1_0_pre2_Phase2_2026D110/FullSimReport/RelMonSummary.html.
PR validation:
I've tested locally the creation of a simple report using two generic DQM files from RelVals with
and the results seems working https://adiflori.web.cern.ch/adiflori/relmon_test/RelMonSummary.html