Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RelMon Piecharts using Chart.js #44977

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented May 15, 2024

PR description:

This PR proposes a solution to the decommissioning of chart.googleapis.com used for RelMon reports, as discussed in #44711 and #44969. Basically it replaces the google api with a js script relying on Chart.js. I'm not an expert so there may be better solutions but it seems to work.

Before integrating it I would allow/ask PdmV developers to test it in a dev instance to see everything works (@ggonzr). I imagine also DQM people would like to test this (@cms-sw/dqm-l2, @nothingface0).

Some further changes done to fix the gauge plots and to make the table more readable and scrollable. See e.g. https://cms-pdmv-prod.web.cern.ch/relmon/1715742438___CMSSW_14_1_0_pre3_Phase2_2026D110vsCMSSW_14_1_0_pre2_Phase2_2026D110/FullSimReport/RelMonSummary.html.

image

PR validation:

I've tested locally the creation of a simple report using two generic DQM files from RelVals with

compare_using_files.py DQM_V0001_R000000001__RelValTTbar_14TeV__CMSSW_14_1_0_pre1-140X_mcRun3_2024_realistic_v1_STD_2024_PU-v1__DQMIO.root DQM_V0001_R000000001__RelValTTbar_14TeV__CMSSW_14_1_0_pre2-PU_140X_mcRun3_2024_realistic_v7_STD_2024_PU-v1__DQMIO.root -C -R -o Test 

and the results seems working https://adiflori.web.cern.ch/adiflori/relmon_test/RelMonSummary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40258

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Utilities/RelMon (dqm)

@rvenditti, @tjavaid, @nothingface0, @syuvivida, @antoniovagnerini, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @wddgit this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@nothingface0
Copy link
Contributor

@AdrianoDee Very nice! You also beat me to it, we were thinking with Geovanny alternatives yesterday and chart.js was a good one.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40261

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44977 was updated. @syuvivida, @cmsbuild, @tjavaid, @antoniovagnerini, @rvenditti, @nothingface0 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40262

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44977 was updated. @syuvivida, @cmsbuild, @rvenditti, @antoniovagnerini, @tjavaid, @nothingface0 can you please check and sign again.

Co-authored-by: Dimitris Papagiannis <[email protected]>
@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44977/40523

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

Pull request #44977 was updated. @tjavaid, @syuvivida, @rvenditti, @antoniovagnerini, @nothingface0 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e7831/39784/summary.html
COMMIT: a2e21c5
CMSSW: CMSSW_14_1_X_2024-06-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44977/39784/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338948
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor Author

AdrianoDee commented Jun 11, 2024

@cms-sw/dqm-l2 any comment left?

@tjavaid
Copy link

tjavaid commented Jun 11, 2024

+1

  • do you plan to open a backport PR for 14_0_X ? @AdrianoDee

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@AdrianoDee
Copy link
Contributor Author

@tjavaid If needed yes, let me know. For us (PdmV) we are fine with 14_1_X

@tjavaid
Copy link

tjavaid commented Jun 11, 2024

@tjavaid If needed yes, let me know. For us (PdmV) we are fine with 14_1_X

Hi @AdrianoDee , I think it is good to have it also in 14_0_X. We (DQM) usually exploit RelMon Picharts for inspection.

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa09b42 into cms-sw:master Jun 12, 2024
11 checks passed
@AdrianoDee AdrianoDee deleted the fix_RelMon_piecharts branch June 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants