Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (14/N) #44958

Merged
merged 1 commit into from
May 14, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 13, 2024

PR description:

Development of HLT menu for CMSSW_13_0_X.
This PR is NOT a backport.

This version of the GRun Frozen HLT menu corresponds to an update to the "V1.2" menu for the 2023 pp data-taking period. This update includes the integration of the following JIRA tickets:

  • CMSHLT-3192 : Add HLT_QuadPFJet70_50_40_35_PNet2BTagMean0p65 to 2023 MC campaign

This update has been request by the HIG PAG to include a trigger path used by the HH4b analysis that was not originally included in the 2023 MC (originally present in the menu version 2023 V1.1, but then removed in CMSHLT-2695). It is the main trigger on which that analysis relies in the pre-parkingHH era, I.e. the first 5.7 fb-1 of 2023 data. With this PR we kindly request to include this trigger in the MC menu for the 2023 MC re-reco that is about to start.

PR validation:

TSG integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be forward-ported.

This version of the GRun Frozen HLT menu corresponds to an update to the "V1.2" menu for the 2023 pp data-taking period.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-3192](https://its.cern.ch/jira/browse/CMSHLT-3192) : Add HLT_QuadPFJet70_50_40_35_PNet2BTagMean0p65 to 2023 MC campaign
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 13, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented May 13, 2024

@cms-sw/ppd-l2 FYI

@mmusich
Copy link
Contributor Author

mmusich commented May 13, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7d755/39350/summary.html
COMMIT: 24bd4ad
CMSSW: CMSSW_13_0_X_2024-05-12-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44958/39350/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283618
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3283562
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.918 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): 0.459 KiB HLT/Filters
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 13, 2024

+hlt

  • changes in the outputs of PR tests are in line with updates and the change in name of the HLT Frozen menu.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

  • Merge as discussed at ORP.

@cmsbuild cmsbuild merged commit 137c853 into cms-sw:CMSSW_13_0_X May 14, 2024
10 checks passed
@mmusich mmusich deleted the HLTdevelopment130X branch May 14, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants