-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce OnlinePopCon mechanism #44927
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40203
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@consuegs, @perrotta, @saumyaphor4252, @francescobrivio, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minors
6526b28
to
d11af0a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40206
|
Pull request #44927 was updated. @saumyaphor4252, @perrotta, @francescobrivio, @cmsbuild, @consuegs can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40536
|
Pull request #44927 was updated. @francescobrivio, @saumyaphor4252, @cmsbuild, @consuegs, @perrotta can you please check and sign again. |
dc43c9f
to
bf36625
Compare
please test |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
I believe the relval failures are unrelated (failing in other recent PRs as well) |
Opened backport to 14_1_X: #46571 |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
ignore tests-rejected with ib-failure |
+1 |
PR description:
This PR introduces a new OnlinePopCon mechanism that will serve the O2Os aiming at writing lumi-based IOVs for HLT.
The implementation is following the same structure of the already existing PopCon mechanism:
PopCon
--> DB upload throughPoolDBOutputService
OnlinePopCon
--> DB upload throughOnlineDBOutputService
and it is largely borrowed from the PopCon code itself, with the appropriate/minimal changes required for running the OnlineDBOutputService.
The first and only (for now) customer of this mechanism are the LHCInfoPerLS and LHCInfoPerFill O2O, when run in "
duringFill
mode".Opening as draft since there are still a few open points to address:
m_dbService->forceInit();
(copied from PopCon) is needed also in OnlinePopConPR Validation
Code compiles, but no other specific validation is done for now.
Backport:
Not a backport.
A backport for the 2024 data-taking release will be opened once we converge on this PR.
FYI @JanChyczynski