Phase2 Fast CPE Template Error Fix

[AdrianoDee]

This PR proposes a trivial fix for the Fast CPE error calculations. As is now only qBin==0 is taken into account and should not be like this. Additionally with #44813 this ends up in an infinite loop (that is also how I spotted it).

Being the original author I honestly don't remember why this was like this in the first place. One of the hypotheses is that the template for Phase 2 pixels was not available at the time of the CUDA port. But I haven't done all the proper archeology.

Fixes for both for Alpaka and CUDA.

Will produce the pixel local reco validation plots and append them here.

[AdrianoDee]

type bug-fix

[cmsbuild]

cms-bot internal usage

[AdrianoDee]

@cms-sw/trk-dpg-l2 I would ask for DPG experts opinion on this.

[AdrianoDee]

please test

[AdrianoDee]

Note: just a first round of tests.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44916/40195

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/src/PixelCPEFast.cc modified in PR(s): introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44916/40195/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44916/40195/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

@emiglior FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44916/40196

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/src/PixelCPEFast.cc modified in PR(s): introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @mroguljic, @tsusa, @mmusich, @VourMa, @threus, @felicepantaleo, @missirol, @ferencek, @JanFSchulte, @VinInn, @dkotlins, @rovere, @tvami, @mtosi, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

please test

[fwyzard]

Thanks @AdrianoDee .
As usual, please make a backport to 14.0.x for the Phase 2 HLT studies :-)

[AdrianoDee]

Sure, done here #44919

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30174b/39276/summary.html
COMMIT: 00b8111
CMSSW: CMSSW_14_1_X_2024-05-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44916/39276/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

• 2500.22500.2_NANOmc124Xrun3/step2_NANOmc124Xrun3.log

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3332476
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3332450
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30174b/39290/summary.html
COMMIT: 00b8111
CMSSW: CMSSW_14_1_X_2024-05-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44916/39290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3332476
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3332441
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1