Propagate downstream the valid state check in PATLeptonTimeLifeInfoProducer #44875

francescobrivio · 2024-04-30T10:24:21Z

PR description:

This is an immediate follow up to #44864.
As nicely explained in #44869 (comment) we need a way to propagate downstream the information in case the closestState.isValid() check introduced in #44864 fails.

In this PR I'm simply moving:

info.setTrack(track);
info.setBField_z(transTrackBuilder.field()->inInverseGeV(GlobalPoint(track->vx(), track->vy(), track->vz())).z());

together with the other methods used to fill the info object and after the check on the track state validity.

PR validation:

Code compiles.
Adding a local cout for info.hasTrack() for the track not passing the state check I correctly get:

> info.hasTrack(): 0

Backport:

Not a backport. This PR will be backported in #44869 together with the backport of #44864

…oducer

cmsbuild · 2024-04-30T10:24:49Z

cms-bot internal usage

francescobrivio · 2024-04-30T10:26:13Z

type tau

francescobrivio · 2024-04-30T10:26:24Z

enable nano

francescobrivio · 2024-04-30T10:28:50Z

urgent

backport is needed for data-taking

cmsbuild · 2024-04-30T10:30:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44875/40134

This PR adds an extra 16KB to repository

cmsbuild · 2024-04-30T10:30:54Z

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

PhysicsTools/PatAlgos (reconstruction, xpog)

@hqucms, @mandrenguyen, @vlimant, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@Ming-Yan, @seemasharmafnal, @Senphy, @hatakeyamak, @nhanvtran, @mbluj, @mariadalfonso, @jdamgov, @azotz, @demuller, @gouskos, @schoef, @jdolen, @AlexDeMoor, @ahinzmann, @gkasieczka, @andrzejnovak, @mmarionncern, @castaned, @gpetruc, @rappoccio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

francescobrivio · 2024-04-30T10:33:02Z

@cmsbuild please test

cmsbuild · 2024-04-30T17:01:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c3f7a/39179/summary.html
COMMIT: 3e37fc5
CMSSW: CMSSW_14_1_X_2024-04-30-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44875/39179/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29661.402 step 3
29661.403 step 3
29834.402 step 2
29834.403 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 52 lines to the logs
Reco comparison results: 49 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3326929
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326906
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 17023
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 17023
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.783	2.783	0.000 ( +0.0% )	3.53	3.58	-1.5%	2.157	2.249
2500.001	2.897	2.897	0.000 ( +0.0% )	3.14	3.18	-1.0%	2.543	2.691
2500.002	2.843	2.843	0.000 ( +0.0% )	3.29	3.30	-0.4%	2.528	2.675
2500.01	1.446	1.446	0.000 ( +0.0% )	6.02	6.19	-2.8%	2.310	2.304
2500.011	1.906	1.906	0.000 ( +0.0% )	3.32	3.32	-0.2%	2.400	2.471
2500.012	1.761	1.761	0.000 ( +0.0% )	4.83	4.82	+0.4%	2.381	2.447
2500.1	2.354	2.354	0.000 ( +0.0% )	4.53	4.56	-0.6%	1.966	2.072
2500.2	2.459	2.459	0.000 ( +0.0% )	5.19	5.26	-1.4%	1.869	1.983
2500.21	1.286	1.286	0.000 ( +0.0% )	3.46	3.51	-1.5%	2.152	2.267
2500.211	1.668	1.668	0.000 ( +0.0% )	3.17	3.26	-2.8%	2.197	2.349
2500.3	2.229	2.229	0.000 ( +0.0% )	10.01	9.85	+1.6%	1.864	1.968
2500.301	2.833	2.833	0.000 ( +0.0% )	8.86	9.08	-2.4%	1.795	1.956
2500.31	7.164	7.164	0.000 ( +0.0% )	1.52	1.45	+4.8%	1.705	1.707
2500.311	1.568	1.568	0.000 ( +0.0% )	8.92	8.51	+4.8%	1.060	1.058
2500.312	540.457	540.457	0.000 ( +0.0% )	0.54	0.54	+0.3%	1.596	1.604
2500.313	817.694	817.694	0.000 ( +0.0% )	0.76	0.75	+1.1%	1.582	1.580
2500.32	1.348	1.348	0.000 ( +0.0% )	12.92	13.08	-1.2%	2.208	2.333
2500.321	1.757	1.757	0.000 ( +0.0% )	10.94	10.96	-0.1%	2.401	2.417
2500.322	1.236	1.236	0.000 ( +0.0% )	10.82	10.59	+2.2%	2.208	2.113
2500.323	7.772	7.772	0.000 ( +0.0% )	4.24	4.36	-2.8%	1.929	1.938
2500.324	1.874	1.874	0.000 ( +0.0% )	10.71	10.49	+2.1%	2.180	2.170
2500.325	4.136	4.136	0.000 ( +0.0% )	4.70	4.69	+0.2%	2.168	2.179
2500.326	3.342	3.342	0.000 ( +0.0% )	1.69	1.69	-0.4%	2.102	2.121
2500.327	1.811	1.811	0.000 ( +0.0% )	11.06	10.65	+3.8%	2.314	2.328
2500.4	2.374	2.374	0.000 ( +0.0% )	9.59	9.54	+0.5%	1.807	1.812
2500.401	1.891	1.891	0.000 ( +0.0% )	8.74	8.77	-0.4%	1.687	1.708
2500.402	2.950	2.950	0.000 ( +0.0% )	8.68	8.75	-0.7%	1.755	1.772
2500.403	8.700	8.700	0.000 ( +0.0% )	3.13	3.12	+0.4%	1.789	1.800
2500.404	5.474	5.474	0.000 ( +0.0% )	1.23	1.22	+0.3%	1.802	1.816
2500.405	2.860	2.860	0.000 ( +0.0% )	8.65	8.86	-2.3%	1.782	1.907
2500.5	5.194	5.194	0.000 ( +0.0% )	16.36	16.38	-0.1%	1.522	1.527
2500.51	9.120	9.120	0.000 ( +0.0% )	9.85	9.86	-0.0%	1.475	1.475

hqucms · 2024-04-30T17:32:19Z

+1

mandrenguyen · 2024-04-30T17:42:25Z

+1

cmsbuild · 2024-04-30T17:42:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

francescobrivio · 2024-04-30T19:39:44Z

@rappoccio @antoniovilela this is now fully signed, can we merge it?
Thanks!
Francesco

antoniovilela · 2024-04-30T20:17:30Z

+1

Propagate downstream the valid state check in PATLeptonTimeLifeInfoPr…

3e37fc5

…oducer

cmsbuild added this to the CMSSW_14_1_X milestone Apr 30, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Apr 30, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2024

cmsbuild added tests-pending tau and removed tests-started labels Apr 30, 2024

cmsbuild added the urgent label Apr 30, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2024

francescobrivio mentioned this pull request Apr 30, 2024

[14_0_X] Add check on PATLeptonTimeLifeInfoProducer closestState valid state #44869

Merged

cmsbuild added tests-approved and removed tests-started labels Apr 30, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Apr 30, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Apr 30, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 30, 2024

cmsbuild merged commit 63c8386 into cms-sw:master Apr 30, 2024
13 checks passed

francescobrivio deleted the alca-propage_change_downstream branch May 5, 2024 09:55

francescobrivio mentioned this pull request May 6, 2024

Crash in PATLeptonTimeLifeInfoProducer.cc in CMSSW_14_0_6 #44862

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate downstream the valid state check in PATLeptonTimeLifeInfoProducer #44875

Propagate downstream the valid state check in PATLeptonTimeLifeInfoProducer #44875

francescobrivio commented Apr 30, 2024

cmsbuild commented Apr 30, 2024 •

edited

Loading

francescobrivio commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

hqucms commented Apr 30, 2024

mandrenguyen commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

antoniovilela commented Apr 30, 2024

Propagate downstream the valid state check in PATLeptonTimeLifeInfoProducer #44875

Propagate downstream the valid state check in PATLeptonTimeLifeInfoProducer #44875

Conversation

francescobrivio commented Apr 30, 2024

PR description:

PR validation:

Backport:

cmsbuild commented Apr 30, 2024 • edited Loading

francescobrivio commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Apr 30, 2024

mandrenguyen commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

francescobrivio commented Apr 30, 2024

antoniovilela commented Apr 30, 2024

cmsbuild commented Apr 30, 2024 •

edited

Loading