-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_0_X] Apply MUDPGNANO EventContent customizations to EDMNANO and NANOSIM as well #44848
[14_0_X] Apply MUDPGNANO EventContent customizations to EDMNANO and NANOSIM as well #44848
Conversation
A new Pull Request was created by @battibass for CMSSW_14_0_X. It involves the following packages:
@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
process.NANOAODoutput.outputCommands.append("drop edmTriggerResults_*_*_*") | ||
for output in ["NANOEDMAODoutput", "NANOAODoutput", "NANOAODSIMoutput"]: | ||
if hasattr(process, output): | ||
getattr(process,output).outputCommands.append("keep nanoaodFlatTable_*Table*_*_*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could change this in the main nano event content @hqucms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vlimant You mean we change keep nanoaodFlatTable_*Table_*_*
to keep nanoaodFlatTable_*Table*_*_*
in NanoAODOutputModule.cc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there and there
"keep nanoaodFlatTable_*Table_*_*", # event data |
941dbce
to
5cdf7d9
Compare
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9c22f/39117/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a backport of PR #44847.
It implements a bugfix, basted on the results of the first tentative of automating the production of the MUDPG custom NANO ntuples described in this JIRA ticket, intended to be deployed in production this year.
PR validation:
No changes expected in
runTheMartrix.py
workflows-w nano -l 2500.312,2500.313
.Change in event content if the
cmsDriver.py
command picked here is ran underCMSSW_14_0_X
.Were both verified.