Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Apply MUDPGNANO EventContent customizations to EDMNANO and NANOSIM as well #44848

Merged

Conversation

battibass
Copy link

PR description:

This is a backport of PR #44847.

It implements a bugfix, basted on the results of the first tentative of automating the production of the MUDPG custom NANO ntuples described in this JIRA ticket, intended to be deployed in production this year.

PR validation:

No changes expected in runTheMartrix.py workflows -w nano -l 2500.312,2500.313.

Change in event content if the cmsDriver.py command picked here is ran under CMSSW_14_0_X.

Were both verified.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass for CMSSW_14_0_X.

It involves the following packages:

  • DPGAnalysis/MuonTools (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2024

cms-bot internal usage

process.NANOAODoutput.outputCommands.append("drop edmTriggerResults_*_*_*")
for output in ["NANOEDMAODoutput", "NANOAODoutput", "NANOAODSIMoutput"]:
if hasattr(process, output):
getattr(process,output).outputCommands.append("keep nanoaodFlatTable_*Table*_*_*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this in the main nano event content @hqucms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlimant You mean we change keep nanoaodFlatTable_*Table_*_* to keep nanoaodFlatTable_*Table*_*_* in NanoAODOutputModule.cc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there and there

"keep nanoaodFlatTable_*Table_*_*", # event data

@cmsbuild
Copy link
Contributor

Pull request #44848 was updated. @hqucms, @cmsbuild, @vlimant can you please check and sign again.

@battibass battibass force-pushed the fix_mudpgnano_eventcontent_140X branch from 941dbce to 5cdf7d9 Compare April 26, 2024 12:27
@cmsbuild
Copy link
Contributor

Pull request #44848 was updated. @vlimant, @hqucms, @cmsbuild can you please check and sign again.

@hqucms
Copy link
Contributor

hqucms commented Apr 26, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 26, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9c22f/39117/summary.html
COMMIT: 5cdf7d9
CMSSW: CMSSW_14_0_X_2024-04-26-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44848/39117/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.94 3.89 +1.3% 2.175 2.174
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.53 3.51 +0.6% 2.595 2.619
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.65 3.63 +0.7% 2.606 2.612
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.75 6.65 +1.5% 2.265 2.262
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.62 3.60 +0.6% 2.411 2.435
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.27 5.22 +1.0% 2.346 2.342
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.13 5.10 +0.5% 2.015 2.075
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.84 5.82 +0.3% 1.905 1.992
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.22 4.17 +1.2% 2.231 2.298
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.75 3.72 +0.9% 2.208 2.263
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.59 11.62 -0.3% 1.978 1.983
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.43 10.36 +0.6% 1.963 1.961
2500.31 1.348 1.348 0.000 ( +0.0% ) 19.12 18.77 +1.9% 2.374 2.381
2500.311 1.757 1.757 0.000 ( +0.0% ) 15.11 14.62 +3.4% 2.343 2.444
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.48 1.49 -0.7% 1.691 1.694
2500.313 1.568 1.568 0.000 ( +0.0% ) 8.84 9.12 -3.1% 1.045 1.045
2500.314 1.236 1.236 0.000 ( +0.0% ) 14.06 13.86 +1.4% 2.237 2.188
2500.315 1.874 1.874 0.000 ( +0.0% ) 14.62 14.44 +1.3% 2.346 2.339
2500.316 3.342 3.342 0.000 ( +0.0% ) 2.02 2.03 -0.2% 2.253 2.307
2500.317 1.811 1.811 0.000 ( +0.0% ) 13.95 13.54 +3.0% 2.166 2.157
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.49 5.48 +0.2% 2.211 2.178
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.47 11.30 +1.5% 1.909 1.907
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.98 9.80 +1.9% 1.696 1.692
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.51 9.84 -3.4% 1.710 1.708
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.43 1.42 +0.7% 1.810 1.803
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.90 9.96 -0.6% 1.741 1.725
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.52 3.50 +0.6% 1.903 1.897
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.83 15.67 +1.0% 1.555 1.565
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.78 9.54 +2.5% 1.550 1.615

@hqucms
Copy link
Contributor

hqucms commented Apr 26, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 64c84ae into cms-sw:CMSSW_14_0_X May 1, 2024
12 checks passed
@battibass battibass deleted the fix_mudpgnano_eventcontent_140X branch August 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants