Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to merge the JSON files produced by the FastTimerService [14.0.x] #44842

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 24, 2024

PR description:

Add script to merge the content of multiple "resources.json" files produced by the FastTimerService, and print the result to standard output.

Usage: mergeResourceJson.py FILE [FILE ...]

Example:

mergeResourceJson.py step*/pid*/resources.json > resources.json

PR validation:

Tested producing 8 JSON files and merging them.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44836 to 14.0.x for timing studies.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Timer (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 24, 2024

backport #44836

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 24, 2024

please test

Just for the signatures

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 24, 2024

@cms-sw/orp-l2 please merge this for the next 14.0.x release at your convenience.

@mmusich
Copy link
Contributor

mmusich commented Apr 24, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

  • added script.

@cmsbuild cmsbuild merged commit ab4ccb0 into cms-sw:CMSSW_14_0_X Apr 24, 2024
7 of 9 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2af56/39078/summary.html
COMMIT: 91eeaca
CMSSW: CMSSW_14_0_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44842/39078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@fwyzard fwyzard deleted the add_mergeResourcesJson_script_140x branch June 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants