[14_0_X]fix skipping qBin when reading template info

[mroguljic]

PR description:

Backport of #44813

Fixes a bug in the alpaka workflow when filling out template information used for error estimation in the generic algorithm for cluster parameter estimation. The current implementation would, for specific module and template combinations, fill information in wrong qBin categories. The effect of this is small as it only affects RecHit position errors for certain modules.

This fix was part of Irradiation Bias Correction at Alpaka PR. I am splitting it in two because IBC needs further studies.

PR validation:

runTheMatrix.py -l limited -i all --ibeos returns 48 47 46 36 19 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

HLT timing comparison was made in 14_0_5 with the /dev/CMSSW_14_0_0/GRun configuration. Throughput between release and release + PR is 587.8 +/- 0.4 evt/s versus 587.0 +/- 2.9

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44813. Backport requested in this PR

[cmsbuild]

A new Pull Request was created by @mroguljic for CMSSW_14_0_X.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@VinInn, @mmusich, @missirol, @mroguljic, @tvami, @felicepantaleo, @GiacomoSguazzoni, @threus, @mtosi, @VourMa, @rovere, @JanFSchulte, @tsusa, @dkotlins, @ferencek, @gpetruc this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from fix skipping qBin when reading template info #44813

[cmsbuild]

cms-bot internal usage

[mmusich]

backport of #44813

[mmusich]

type bug-fix

[mandrenguyen]

How urgent is this for data taking?
This wasn't discussed in the context of the CMSSW_14_0_6 at the ORP yesterday, if I recall correctly.
Based on the comment in the PR description "The effect of this is small as it only affects RecHit position errors for certain modules", do I interpret that this can wait for a subsequent release?

[mandrenguyen]

please test

[mroguljic]

Based on the comment in the PR description "The effect of this is small as it only affects RecHit position errors for certain modules", do I interpret that this can wait for a subsequent release?

Yes

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b094b7/39045/summary.html
COMMIT: d00aa7e
CMSSW: CMSSW_14_0_X_2024-04-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44816/39045/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 90 lines to the logs
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319088
• DQMHistoTests: Total failures: 7469
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3311599
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[mandrenguyen]

+reconstruction
Does not need to be included for 14_0_6, which is already in the pipeline, but needed for data taking (HLT) at the next opportunity.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1