-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DT DQM] Fix some minor style bugs #44800
Conversation
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44800/40036
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages:
@tjavaid, @rvenditti, @syuvivida, @nothingface0, @antoniovagnerini can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e8c90/38991/summary.html Comparison SummarySummary:
|
Added an additional commit to fix a weird behaviour spotted during a test in ONline DQM playback, now it should be OK. I am sorry for the inconvenience. Thanks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44800/40116
|
Pull request #44800 was updated. @nothingface0, @rvenditti, @cmsbuild, @tjavaid, @antoniovagnerini, @syuvivida can you please check and sign again. |
please test |
Pull request #44800 was updated. @syuvivida, @nothingface0, @antoniovagnerini, @rvenditti, @tjavaid, @cmsbuild can you please check and sign again. |
Final version of the PR |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44800/40139
|
Pull request #44800 was updated. @tjavaid, @antoniovagnerini, @rvenditti, @syuvivida, @nothingface0 can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e8c90/39186/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
Online DQM playback looks correct. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@jfernan2 could you make a backport of this PR to 14_0_X so that it could be included in the next 14_0_X release? Thanks!! |
PR description:
This PR fixes some minor DT DQM style bugs spotted during the review of the DT DOC documentation
Changes bring in sync the info in the GUI with that on the DT Twikis
This PR affects both Online and Ofline GUIs
PR validation:
Validated on private DQM GUI.
No backport needed