Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT DQM] Fix some minor style bugs #44800

Merged
merged 5 commits into from
May 2, 2024

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Apr 22, 2024

PR description:

This PR fixes some minor DT DQM style bugs spotted during the review of the DT DOC documentation

Changes bring in sync the info in the GUI with that on the DT Twikis

This PR affects both Online and Ofline GUIs

PR validation:

Validated on private DQM GUI.

No backport needed

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44800/40036

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

  • DQM/DTMonitorClient (dqm)
  • DQM/DTMonitorModule (dqm)

@tjavaid, @rvenditti, @syuvivida, @nothingface0, @antoniovagnerini can you please review it and eventually sign? Thanks.
@battibass, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e8c90/38991/summary.html
COMMIT: ed5af64
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44800/38991/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor Author

Added an additional commit to fix a weird behaviour spotted during a test in ONline DQM playback, now it should be OK. I am sorry for the inconvenience. Thanks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44800/40116

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44800 was updated. @nothingface0, @rvenditti, @cmsbuild, @tjavaid, @antoniovagnerini, @syuvivida can you please check and sign again.

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #44800 was updated. @syuvivida, @nothingface0, @antoniovagnerini, @rvenditti, @tjavaid, @cmsbuild can you please check and sign again.

@jfernan2
Copy link
Contributor Author

Final version of the PR

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44800/40139

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44800 was updated. @tjavaid, @antoniovagnerini, @rvenditti, @syuvivida, @nothingface0 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e8c90/39186/summary.html
COMMIT: 0c0b41d
CMSSW: CMSSW_14_1_X_2024-04-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44800/39186/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29661.402 step 3
29661.403 step 3
29834.402 step 2
29834.403 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@jfernan2
Copy link
Contributor Author

jfernan2 commented May 1, 2024

Online DQM playback looks correct.
Green light from my side to deploy.
Thanks a lot @antoniovagnerini !!

@antoniovagnerini
Copy link

+1
Tested in playback machine with collision run 379315 and since no issues observed it was then deployed online http://cmsonline.cern.ch/cms-elog/1213060

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c2ea811 into cms-sw:master May 2, 2024
11 checks passed
@syuvivida
Copy link
Contributor

@jfernan2 could you make a backport of this PR to 14_0_X so that it could be included in the next 14_0_X release? Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants