Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Added missing header to fix header consistency #44762

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

smuzaffar
Copy link
Contributor

This should fix the header consistency error we have in 14.0.X IBs

src/HeterogeneousCore/AlpakaCore/interface/alpaka/ProducerBase.h: In member function 'void alpaka_serial_sync::ProducerBase<BaseT, Args>::producesTemporarily(const std::string&, std::string)':
src/HeterogeneousCore/AlpakaCore/interface/alpaka/ProducerBase.h:62:22: error: 'edm::TypeWithDict' has not been declared
   62 |       auto td = edm::TypeWithDict::byName(iTypeName);
      |                      ^~~~~~~~~~~~
src/HeterogeneousCore/AlpakaCore/interface/alpaka/ProducerBase.h:63:60: error: 'TypeID' is not a member of 'edm'
   63 |       Base::template produces<edm::Transition::Event>(edm::TypeID(td.typeInfo()), std::move(instanceName));
      |                                                            ^~~~~~
src/HeterogeneousCore/AlpakaCore/interface/alpaka/ProducerBase.h: In member function 'void alpaka_serial_sync::ProducerBase<BaseT, Args>::putBackend(edm::Event&) const':
src/HeterogeneousCore/AlpakaCore/interface/alpaka/ProducerBase.h:73:7: warning: invalid use of incomplete type 'class edm::Event'
   73 |       iEvent.emplace(this->backendToken_, static_cast<unsigned short>(kBackend));
      |       ^~~~~~
In file included from src/HeterogeneousCore/AlpakaCore/interface/alpaka/ProducerBase.h:5:
/data/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_14_0_X_2024-04-17-1100/src/FWCore/Framework/interface/FrameworkfwdMostUsed.h:12:9: note: forward declaration of 'class edm::Event'
   12 |   class Event;
      |         ^~~~~
gmake: *** [config/SCRAM/GMake/Makefile.rules:1847: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaCore/src/HeterogeneousCoreAlpakaCore/alpaka/ProducerBase.h.chk_header] Error 1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)

@fwyzard, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@rovere, @missirol, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@makortel
Copy link
Contributor

@cmsbuild, please test

@makortel
Copy link
Contributor

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f62a2/38894/summary.html
COMMIT: e665b01
CMSSW: CMSSW_14_0_X_2024-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44762/38894/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3318804
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3318772
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb413c5 into cms-sw:CMSSW_14_0_X Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants