Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: reportSummaryMap: change the sqrt(s) energy from 13 to 13.6 TeV #44757

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

syuvivida
Copy link
Contributor

PR description:

This PR changes the display of sqrt(s) energy in the reportSummaryMap from 13 TeV to 13.6 TeV. Before this PR request, an update of DQMGUI layout was already committed and merged: github link. The PR in DQMGUI layout ensures there is no problem when rendering two different version of root files (one with 13 TeV and the other with 13.6 TeV).

PR validation:

We have tested this PR at the playback machines using DQM streamers of cosmic run 378711, 900 GeV pp run 378239, 13.6 TeV pp run 379315. All displayed as expected in the reportSummaryMap.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@syuvivida syuvivida changed the title [DQM] reportSummaryMap: change the sqrt(s) energy from 13 to 13.6 TeV DQM: reportSummaryMap: change the sqrt(s) energy from 13 to 13.6 TeV Apr 17, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44757/39977

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @syuvivida for master.

It involves the following packages:

  • DQMServices/Components (dqm)

@antoniovagnerini, @rvenditti, @syuvivida, @nothingface0, @cmsbuild, @tjavaid can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Apr 18, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6952f/38937/summary.html
COMMIT: c3001de
CMSSW: CMSSW_14_1_X_2024-04-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44757/38937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 55 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319599
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319567
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Apr 25, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0393dfe into cms-sw:master Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants