Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PUPPI jets and METs to offline DQM - backport to 14_0_X #44752

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

rseidita
Copy link
Contributor

PR description:

Adding the PUPPI collection for both jets and METs to the offline DQM JetMET sequence, as presented here.

PR validation:

echo '{
"369978" : [[1, 800]]
}' > step1_lumiRanges.log  2>&1

(dasgoclient --limit 0 --query 'lumi,file dataset=/JetMET0/Run2023D-v1/RAW run=369978' --format json | das-selected-lumis.py 1,800 ) | sort -u > step1_dasquery.log  2>&1

cmsDriver.py step2  --process reHLT -s L1REPACK:Full,HLT:@relval2023 --conditions auto:run3_hlt_relval --data  --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3_2023 -n 1000 --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root  --nThreads 8

cmsDriver.py step3  --conditions auto:run3_data_prompt_relval -s RAW2DIGI,L1Reco,RECO,PAT,NANO,DQM:@jetmet --datatier RECO,MINIAOD,NANOAOD,DQMIO --eventcontent RECO,MINIAOD,NANOEDMAOD,DQM --data  --process reRECO --scenario pp --era Run3_2023 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3 --hltProcess reHLT -n 1000 --filein  file:step2.root  --fileout file:step3.root  --nThreads 8

cmsDriver.py step4  -s HARVESTING:@jetmet --conditions auto:run3_data --data  --filetype DQM --scenario pp --era Run3_2023 -n 1000 --filein file:step3_inDQM.root --fileout file:step4.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of PR#44336

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2024

A new Pull Request was created by @rseidita for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/JetMET (dqm)

@cmsbuild, @tjavaid, @nothingface0, @syuvivida, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@jdamgov, @nhanvtran, @gkasieczka, @ahinzmann, @mmarionncern, @rociovilar, @schoef, @mariadalfonso, @seemasharmafnal, @rappoccio, @jdolen this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2024

cms-bot internal usage

@rseidita rseidita changed the title Patch 3 Adding PUPPI jets and METs to offline DQM - backport to 14_0_X Apr 16, 2024
@tjavaid
Copy link

tjavaid commented Apr 17, 2024

backport of #44336

@tjavaid
Copy link

tjavaid commented Apr 17, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32b423/38880/summary.html
COMMIT: 5c8c11c
CMSSW: CMSSW_14_0_X_2024-04-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44752/38880/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3318804
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 195
  • DQMHistoTests: Total successes: 3318585
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3605.085 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 127.810 KiB JetMET/MET
  • DQMHistoSizes: changed ( 1000.0 ): 43.835 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10224.0,... ): 43.851 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 13234.0,... ): 0.016 KiB JetMET/Jet
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

urgent
Needed for data taking, according to:
https://docs.google.com/document/d/1QXXZiwxU_zbDCqAeCt9vKDDJ3LUjEduK5-mXVO9w1GI/edit
-Matt (ORM)

@syuvivida
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

  • Let's rely on PR tests and fast-track this backport targetting 14_0_6.

@cmsbuild cmsbuild merged commit ae12a41 into cms-sw:CMSSW_14_0_X Apr 24, 2024
10 checks passed
@rseidita rseidita deleted the patch-3 branch April 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants