Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PSet of EvFDaqDirector in convertToRaw.py [14_0_X] #44736

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Apr 15, 2024

backport of #44735

PR description:

From the description of #44735.

This PR updates convertToRaw.py in order to adapt to the fillDescriptions changes introduced in #43850. The utility convertToRaw does not currently work in 14_0_X and 14_1_X without this change. The change is merely technical: none of the values of the existing parameters are changed. A typo in convertToRaw is also fixed.

Merely technical. No changes expected.

(It would be good to add a unit test for this utility, but I currently do not have enough time to implement a proper one, and I would not delay this fix.)

FYI: @fwyzard

PR validation:

None beyond the validation done for #44735.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#44735

Backported for trigger studies on 2024 data.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2024

A new Pull Request was created by @missirol for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Tools (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fwyzard, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2024

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a94e57/38845/summary.html
COMMIT: 3b4e97c
CMSSW: CMSSW_14_0_X_2024-04-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44736/38845/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3309849
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3309823
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5e41534 into cms-sw:CMSSW_14_0_X Apr 16, 2024
10 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a94e57/38867/summary.html
COMMIT: 3b4e97c
CMSSW: CMSSW_14_0_X_2024-04-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44736/38867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 82 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3318804
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3318778
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants