Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Photon HoE variable needed for H(gg) analysis #44725

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Addition of Photon HoE variable needed for H(gg) analysis #44725

merged 4 commits into from
Apr 15, 2024

Conversation

TizianoBevilacqua
Copy link
Contributor

PR description:

With this pull request I added the two versions of Photon HoE calculation to the nAOD variable output. Previously for run 3 the HoE dumped was calo based while for run 2 it was Tower based. Both are needed in both cases for H(gg) analyses.

PR validation:

To test I've created a nAOD starting from Run2 data samples and checked that both version of HoE are dumped correctly

@lfinco @fcouderc

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 12, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024 •
edited
Loading

A new Pull Request was created by @TizianoBevilacqua for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #44725 was updated. @vlimant, @hqucms, @cmsbuild can you please check and sign again.

hqucms
hqucms reviewed Apr 12, 2024
View reviewed changes
PhysicsTools/NanoAOD/python/photons_cff.py Outdated
@@ -228,6 +228,7 @@ def make_bitmapVID_docstring(id_modules_working_points_pset):
pfRelIso03_chg_quadratic = Var("userFloat('PFIsoChgQuadratic')/pt",float,doc="PF relative isolation dR=0.3, charged hadron component (with quadraticEA*rho*rho + linearEA*rho Winter22V1 corrections)"),
pfRelIso03_all_quadratic = Var("userFloat('PFIsoAllQuadratic')/pt",float,doc="PF relative isolation dR=0.3, total (with quadraticEA*rho*rho + linearEA*rho Winter22V1 corrections)"),
hoe = Var("hadronicOverEm()",float,doc="H over E",precision=8),
hoe_TowOverEm = Var("hadTowOverEm()",float,doc="H over E Tower based calculation",precision=8),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TizianoBevilacqua I found the name hoe_TowOverEm a bit confusing as oe:=OverEm. Would it be better to just call it hadTowOverEm or hoe_Tower?

@cmsbuild
Copy link
Contributor

Pull request #44725 was updated. @hqucms, @cmsbuild, @vlimant can you please check and sign again.

@hqucms
Copy link
Contributor

hqucms commented Apr 12, 2024

@TizianoBevilacqua I just realized that you opened this pull request directly to 14_0_X. Please first open one for the master branch.

@hqucms
Copy link
Contributor

hqucms commented Apr 12, 2024

backport of #44728

@hqucms
Copy link
Contributor

hqucms commented Apr 12, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c537c/38827/summary.html
COMMIT: 5e410ce
CMSSW: CMSSW_14_0_X_2024-04-12-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44725/38827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 95 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 106 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308451
  • DQMHistoTests: Total failures: 1361
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307070
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.8090000000000006 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.247 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.120 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16461
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.569 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.247 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.120 KiB Physics/NanoAODDQM
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.556 2.553 0.003 ( +0.1% ) 5.14 5.19 -0.9% 2.149 2.158
2500.001 2.706 2.703 0.003 ( +0.1% ) 4.62 4.67 -1.1% 2.566 2.594
2500.002 2.647 2.643 0.003 ( +0.1% ) 4.79 4.84 -1.0% 2.566 2.575
2500.01 1.321 1.318 0.002 ( +0.2% ) 9.27 9.41 -1.5% 2.250 2.265
2500.011 1.743 1.740 0.003 ( +0.2% ) 5.07 5.13 -1.2% 2.405 2.425
2500.012 1.584 1.581 0.003 ( +0.2% ) 7.19 7.28 -1.2% 2.302 2.318
2500.1 2.199 2.197 0.001 ( +0.1% ) 5.19 5.23 -0.8% 1.998 2.006
2500.2 2.316 2.314 0.002 ( +0.1% ) 5.91 5.97 -1.1% 1.892 1.894
2500.21 1.185 1.182 0.002 ( +0.2% ) 4.25 4.27 -0.6% 2.167 2.183
2500.211 1.549 1.546 0.003 ( +0.2% ) 3.66 3.66 +0.0% 2.196 2.191
2500.3 2.066 2.065 0.002 ( +0.1% ) 11.95 12.39 -3.5% 1.905 1.905
2500.301 2.640 2.637 0.003 ( +0.1% ) 9.90 10.15 -2.4% 1.841 1.845
2500.31 1.257 1.255 0.002 ( +0.2% ) 18.95 19.92 -4.9% 2.273 2.273
2500.311 1.643 1.641 0.002 ( +0.1% ) 13.38 13.45 -0.6% 2.326 2.326
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.37 1.39 -1.2% 1.697 1.696
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.37 7.18 -11.3% 1.054 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.69 13.78 -0.7% 2.232 2.195
2500.315 1.760 1.757 0.002 ( +0.1% ) 13.26 14.19 -6.6% 2.326 2.335
2500.316 3.095 3.093 0.002 ( +0.1% ) 2.17 2.16 +0.2% 2.132 2.157
2500.317 1.791 1.788 0.002 ( +0.1% ) 13.09 13.46 -2.7% 2.135 2.179
2500.4 2.230 2.226 0.004 ( +0.2% ) 11.64 12.04 -3.3% 1.888 1.886
2500.401 1.749 1.749 0.000 ( +0.0% ) 9.87 10.33 -4.4% 1.806 1.717
2500.402 2.773 2.770 0.003 ( +0.1% ) 9.53 9.99 -4.6% 1.742 1.763
2500.403 5.083 5.080 0.003 ( +0.1% ) 1.56 1.61 -3.1% 1.784 1.813
2500.404 2.781 2.778 0.003 ( +0.1% ) 9.30 9.78 -5.0% 1.788 1.831
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.35 15.93 -3.6% 1.595 1.620
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.60 9.72 -1.2% 1.661 1.663

@hqucms
Copy link
Contributor

hqucms commented Apr 13, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17e676b into cms-sw:CMSSW_14_0_X Apr 15, 2024
12 checks passed
@RSalvatico
Copy link
Contributor

type egamma

@cmsbuild cmsbuild added the egamma label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hqucms hqucms hqucms left review comments

Assignees
No one assigned
Labels
backport-ok egamma fully-signed orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@TizianoBevilacqua @cmsbuild @hqucms @antoniovilela @RSalvatico