Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit acelerator types in alpaka tests [14.0.x] #44703

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 10, 2024

PR description:

Update the HeterogeneousTest alpaka tests to use the explicit accelerator types in alpaka device code:

  • move all alpaka device code to the ALPAKA_ACCELERATOR_NAMESPACE namespace;
  • use the explicit accelerator types, like Acc1D or Acc2D, instead of the generic TAcc template argument.

PR validation:

The HeterogeneousTest unit tests pass:

Creating test log file logs/el8_amd64_gcc12/testing.log
Pass    3s ... HeterogeneousTest/AlpakaDevice/testAlpakaDeviceAdditionCudaAsync
Skip    0s ... HeterogeneousTest/AlpakaDevice/testAlpakaDeviceAdditionROCmAsync (Failed to run rocmIsEnabled)
Pass    0s ... HeterogeneousTest/AlpakaDevice/testAlpakaDeviceAdditionSerialSync
Pass   10s ... HeterogeneousTest/AlpakaDevice/testAlpakaTestDeviceAdditionModule
Pass    3s ... HeterogeneousTest/AlpakaKernel/testAlpakaDeviceAdditionKernelCudaAsync
Skip    0s ... HeterogeneousTest/AlpakaKernel/testAlpakaDeviceAdditionKernelROCmAsync (Failed to run rocmIsEnabled)
Pass    0s ... HeterogeneousTest/AlpakaKernel/testAlpakaDeviceAdditionKernelSerialSync
Pass    7s ... HeterogeneousTest/AlpakaKernel/testAlpakaTestKernelAdditionModule
Pass    3s ... HeterogeneousTest/AlpakaOpaque/testAlpakaDeviceAdditionOpaqueCudaAsync
Skip    0s ... HeterogeneousTest/AlpakaOpaque/testAlpakaDeviceAdditionOpaqueROCmAsync (Failed to run rocmIsEnabled)
Pass    0s ... HeterogeneousTest/AlpakaOpaque/testAlpakaDeviceAdditionOpaqueSerialSync
Pass    7s ... HeterogeneousTest/AlpakaOpaque/testAlpakaTestAdditionModules
Pass    7s ... HeterogeneousTest/AlpakaOpaque/testAlpakaTestOpaqueAdditionModule
Pass    3s ... HeterogeneousTest/AlpakaWrapper/testAlpakaDeviceAdditionWrapperCudaAsync
Skip    0s ... HeterogeneousTest/AlpakaWrapper/testAlpakaDeviceAdditionWrapperROCmAsync (Failed to run rocmIsEnabled)
Pass    0s ... HeterogeneousTest/AlpakaWrapper/testAlpakaDeviceAdditionWrapperSerialSync
Pass    7s ... HeterogeneousTest/AlpakaWrapper/testAlpakaTestWrapperAdditionModule
>> Test sequence completed for CMSSW CMSSW_14_1_X_2024-04-08-2300

Backport status:

Backport of #44676 to 14.0.x, for consistency.

Move all alpaka device code to the ALPAKA_ACCELERATOR_NAMESPACE namespace.

Use the explicit accelerator types, like Acc1D or Acc2D, instead of the
generic TAcc template argument.
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 10, 2024

backport #44676

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 10, 2024

enable gpu

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 10, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 10, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousTest/AlpakaDevice (heterogeneous)
  • HeterogeneousTest/AlpakaKernel (heterogeneous)
  • HeterogeneousTest/AlpakaWrapper (heterogeneous)

@fwyzard, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74ac12/38761/summary.html
COMMIT: 9a0bcd7
CMSSW: CMSSW_14_0_X_2024-04-10-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44703/38761/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1944
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 37796
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 11, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 289d578 into cms-sw:CMSSW_14_0_X Apr 12, 2024
13 checks passed
@fwyzard fwyzard deleted the implement_HeterogeneousTest_Alpaka_alt_140x branch June 13, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants