-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit acelerator types in alpaka tests [14.0.x] #44703
Use explicit acelerator types in alpaka tests [14.0.x] #44703
Conversation
Move all alpaka device code to the ALPAKA_ACCELERATOR_NAMESPACE namespace. Use the explicit accelerator types, like Acc1D or Acc2D, instead of the generic TAcc template argument.
backport #44676 |
enable gpu |
please test |
A new Pull Request was created by @fwyzard for CMSSW_14_0_X. It involves the following packages:
@fwyzard, @cmsbuild, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74ac12/38761/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update the
HeterogeneousTest
alpaka tests to use the explicit accelerator types in alpaka device code:ALPAKA_ACCELERATOR_NAMESPACE
namespace;Acc1D
orAcc2D
, instead of the genericTAcc
template argument.PR validation:
The
HeterogeneousTest
unit tests pass:Backport status:
Backport of #44676 to 14.0.x, for consistency.