Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Removed pixelLayers requirement in MuonSelectors.cc #44697

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

fmanteca
Copy link
Contributor

PR description:

Removed pixelLayers requirement in loose muon Trigger ID to improve the efficiency for low pt muons.

HLT efficiency, rate, and timing estimates are given at https://its.cern.ch/jira/browse/CMSHLT-3079

PR validation:

https://its.cern.ch/jira/browse/CMSHLT-3079

@cmssw/hlt-l2

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44692

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

A new Pull Request was created by @fmanteca for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/MuonReco (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@rovere, @JanFSchulte, @trocino, @cericeci, @abbiendi, @amagitte, @HuguesBrun, @battibass, @missirol, @jhgoh, @Fedespring, @andrea21z, @CeliaFernandez this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

type muon

@jfernan2
Copy link
Contributor

backport of #44692

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

@cms-sw/hlt-l2 FYI

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eae11/38760/summary.html
COMMIT: f19939c
CMSSW: CMSSW_14_0_X_2024-04-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44697/38760/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eae11/38760/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4eae11/38760/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 57 lines from the logs
  • Reco comparison results: 28829 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3350124
  • DQMHistoTests: Total failures: 17836
  • DQMHistoTests: Total nulls: 17
  • DQMHistoTests: Total successes: 3332249
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.05500000000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 140.023 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.043 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.062 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.047 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.074 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 51476e1 into cms-sw:CMSSW_14_0_X Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants