Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tau Filterbits for 2024 Data Taking [Backport] #44690

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Updated Tau Filterbits for 2024 Data Taking [Backport] #44690

merged 1 commit into from
Apr 12, 2024

Conversation

brallmond
Copy link
Contributor

@brallmond brallmond commented Apr 10, 2024

This PR is to update filterbits in NanoAOD V14 for 2024 data taking, and for 2022/2023 ReReco campaigns.

The PR adds filter bits for Tau ParticleNet at HLT filters to the electron, muon, tau, and jet collections.
The PR also re-arranges the order of some Tau filter bits, as part of combining/making room for the new bits.

To fit the PNet bits into the Tau collection (since there cannot be more than 30 bits), it was necessary to double-up the DeepTau and Pnet signal and monitoring filter bits. It is possible to do this by requiring an additional bit that is exclusively PNet or DeepTau.
In the process of implementing the PNet bits, several non-functioning DeepTau bits were also updated, enabling more Tau triggers to be matched, specifically VBF SingleTau.

The changes were tested by re-emulating signal files from the HLT decision to NanoAOD, and then observing the filter bits at the NanoAOD level.

This PR is a backport of #44688. The backport is necessary because 14_0_X is the release that will be used during proton-proton data-taking, and the filter bit changes are necessary for smooth Tau Trigger operation during proton-proton collisions.

head PR: #44688
intended release cycle: 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

A new Pull Request was created by @brallmond for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

Backport of #44688

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

please test

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

@brallmond Could you please update the title of the PR to indicate it's a backport?

@brallmond brallmond changed the title updated tau filterbits for 2024 data taking Updated Tau Filterbits for 2024 Data Taking [Backport] Apr 10, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f72e5b/38735/summary.html
COMMIT: 3162428
CMSSW: CMSSW_14_0_X_2024-04-10-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44690/38735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 88 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 176
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16294
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 0.000 ( +0.0% ) 5.24 5.24 +0.0% 2.241 2.137
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.69 4.68 +0.1% 2.648 2.531
2500.002 2.643 2.643 0.000 ( +0.0% ) 4.87 4.88 -0.2% 2.639 2.529
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.67 9.47 +2.1% 2.347 2.239
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.22 5.17 +0.8% 2.549 2.400
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.45 7.30 +2.1% 2.361 2.286
2500.1 2.240 2.197 0.042 ( +1.9% ) 5.23 5.30 -1.3% 2.069 1.981
2500.2 2.346 2.314 0.032 ( +1.4% ) 6.01 6.03 -0.3% 1.985 1.885
2500.21 1.198 1.182 0.015 ( +1.3% ) 4.29 4.30 -0.3% 2.268 2.170
2500.211 1.566 1.546 0.020 ( +1.3% ) 3.80 3.79 +0.3% 2.358 2.255
2500.3 2.114 2.065 0.049 ( +2.4% ) 12.18 12.56 -3.0% 1.978 1.976
2500.301 2.701 2.637 0.064 ( +2.4% ) 9.95 10.41 -4.4% 1.958 1.959
2500.31 1.279 1.255 0.024 ( +1.9% ) 19.85 20.15 -1.5% 2.366 2.365
2500.311 1.670 1.641 0.029 ( +1.8% ) 13.58 13.95 -2.7% 2.442 2.334
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.45 1.46 -1.2% 1.699 1.699
2500.313 1.564 1.564 0.000 ( +0.0% ) 7.36 7.12 +3.3% 1.054 1.052
2500.314 1.192 1.163 0.029 ( +2.5% ) 13.29 13.81 -3.8% 2.256 2.223
2500.315 1.787 1.757 0.030 ( +1.7% ) 14.08 14.48 -2.8% 2.330 2.328
2500.316 3.122 3.093 0.029 ( +1.0% ) 2.23 2.26 -1.3% 2.279 1.859
2500.317 1.818 1.788 0.029 ( +1.6% ) 13.22 13.82 -4.3% 2.158 2.134
2500.4 2.286 2.226 0.060 ( +2.7% ) 11.93 12.21 -2.3% 1.887 1.877
2500.401 1.826 1.749 0.077 ( +4.4% ) 10.36 10.35 +0.1% 1.819 1.719
2500.402 2.848 2.770 0.078 ( +2.8% ) 10.00 10.21 -2.0% 1.777 1.786
2500.403 5.158 5.080 0.078 ( +1.5% ) 1.59 1.62 -1.9% 1.824 1.755
2500.404 2.856 2.778 0.078 ( +2.8% ) 9.90 9.87 +0.3% 1.913 1.696
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.95 15.84 +0.7% 1.613 1.624
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.78 9.82 -0.4% 1.654 1.659

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@hqucms
Copy link
Contributor

hqucms commented Apr 10, 2024

type tau

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa35571 into cms-sw:CMSSW_14_0_X Apr 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants