Tunable `PUMax` in `PrimaryVertexMonitor` and Finer d_xy DQM Tracking Plots #44669

AdrianoDee · 2024-04-09T11:23:50Z

A couple of minor fixes for tracking DQM plots:

have tunable PU maximum for PrimaryVErtexMonitor;
have finer dxy binning and smaller range for the MTV.

cmsbuild · 2024-04-09T11:24:11Z

cms-bot internal usage

cmsbuild · 2024-04-09T11:30:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44669/39869

This PR adds an extra 20KB to repository

cmsbuild · 2024-04-09T11:31:05Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

DQMOffline/RecoB (dqm)

@antoniovagnerini, @cmsbuild, @rvenditti, @tjavaid, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks.
@rociovilar, @demuller, @Ming-Yan, @emilbols, @AlexDeMoor, @JyothsnaKomaragiri, @andrzejnovak, @Senphy, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-04-09T11:35:55Z

please test

cmsbuild · 2024-04-09T14:45:24Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f29e57/38704/summary.html
COMMIT: 69fc582
CMSSW: CMSSW_14_1_X_2024-04-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44669/38704/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2500.3232500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

Comparison Summary

Summary:

You potentially removed 26 lines from the logs
Reco comparison results: 44 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3308887
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 132
DQMHistoTests: Total successes: 3308729
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 37.19599999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.547 KiB OfflinePV/offlinePrimaryVertices
DQMHistoSizes: changed ( 12834.0,... ): 1.641 KiB HLT/Vertexing
DQMHistoSizes: changed ( 23234.0,... ): 1.094 KiB HLT/Vertexing
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-04-10T07:51:55Z

please test

mmusich · 2024-04-10T07:55:31Z

DQMOffline/RecoB/plugins/PrimaryVertexMonitor.cc

-  nbvtx = iBooker.book1D("vtxNbr", "Reconstructed Vertices in Event", 80, -0.5, 79.5);
-  nbgvtx = iBooker.book1D("goodvtxNbr", "Reconstructed Good Vertices in Event", 80, -0.5, 79.5);
+  nbvtx = iBooker.book1D("vtxNbr", "Reconstructed Vertices in Event", 150, -0.5, 149.5);
+  nbgvtx = iBooker.book1D("goodvtxNbr", "Reconstructed Good Vertices in Event", 150, -0.5, 149.5);


since you're touching it, perhaps you can make it more future proof, by using the era modifiers

cmssw/DQMOffline/RecoB/python/PrimaryVertexMonitor_cff.py

Lines 32 to 38 in 1471374

# same as above, should be in sync with cut used in Vertex finder...

from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel

from Configuration.Eras.Modifier_run3_common_cff import run3_common

from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker

phase1Pixel.toModify(pvMonitor, EtaBin=28, EtaMin=-2.7, EtaMax=2.7)

run3_common.toModify(pvMonitor, Xpos = 0.15, Ypos=-0.15) #recentering since initial Run3 beamspot is at (0.17,-0.18) cm

phase2_tracker.toModify(pvMonitor, EtaBin=41, EtaBin2D=9, EtaMin=-4.0, EtaMax=4.0)

and put larger values also for Phase-2.

Sure, I hadn't noticed the problem was there also for Phase2. Let me fix it.

I think I will take the chance to update few other parameters that are off.

@AdrianoDee ping.

cmsbuild · 2024-04-10T10:50:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f29e57/38730/summary.html
COMMIT: 69fc582
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44669/38730/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 24 lines from the logs
Reco comparison results: 37 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3316263
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 132
DQMHistoTests: Total successes: 3316111
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 37.19599999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.547 KiB OfflinePV/offlinePrimaryVertices
DQMHistoSizes: changed ( 12834.0,... ): 1.641 KiB HLT/Vertexing
DQMHistoSizes: changed ( 23234.0,... ): 1.094 KiB HLT/Vertexing
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

slava77 · 2024-05-31T22:22:00Z

@AdrianoDee
please clarify on the status of this PR.
Thank you.

AdrianoDee · 2024-06-04T16:38:02Z

@AdrianoDee please clarify on the status of this PR. Thank you.

Hi Slava, I can come back to this during this week.

AdrianoDee · 2024-06-07T13:44:49Z

please test

cmsbuild · 2024-06-07T13:46:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44669/40520

This PR adds an extra 20KB to repository

cmsbuild · 2024-06-07T13:47:22Z

Pull request #44669 was updated. @nothingface0, @tjavaid, @antoniovagnerini, @rvenditti, @syuvivida can you please check and sign again.

cmsbuild · 2024-06-07T17:09:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f29e57/39780/summary.html
COMMIT: 4f7fbc0
CMSSW: CMSSW_14_1_X_2024-06-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44669/39780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3445482
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 38007
DQMHistoTests: Total successes: 3407455
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 72424.84199999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 3.125 KiB OfflinePV/offlineBeamSpot
DQMHistoSizes: changed ( 10224.0,... ): 2100.000 KiB Tracking/Track
DQMHistoSizes: changed ( 10224.0,... ): 562.500 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 10224.0,... ): 196.875 KiB Tracking/JetCore
DQMHistoSizes: changed ( 10224.0,... ): 164.062 KiB Tracking/TrackBuilding
DQMHistoSizes: changed ( 10224.0,... ): 43.750 KiB Tracking/TrackConversion
DQMHistoSizes: changed ( 10224.0,... ): 43.750 KiB Tracking/TrackFromPV
DQMHistoSizes: changed ( 10224.0,... ): 31.250 KiB Tracking/TrackFromPVAllTP
DQMHistoSizes: changed ( 10224.0,... ): 21.875 KiB Tracking/TrackAllTPEffic
DQMHistoSizes: changed ( 10224.0,... ): 10.938 KiB Tracking/TrackGsf
DQMHistoSizes: changed ( 11634.0 ): ...
Checked 206 log files, 170 edm output root files, 49 DQM output files
TriggerResults: no differences found

tjavaid · 2024-06-13T02:39:37Z

@mmusich , are you happy with the updates ?

mmusich · 2024-06-13T06:35:16Z

are you happy with the updates ?

@tjavaid, sure, let's go ahead.

tjavaid · 2024-06-13T06:45:00Z

+1

@AdrianoDee , do you plan to open its backport PR to 14_0_X ?

cmsbuild · 2024-06-13T06:45:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-06-13T15:08:17Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Apr 9, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Apr 9, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 9, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 9, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 9, 2024

cmsbuild added tests-started and removed tests-rejected labels Apr 10, 2024

mmusich reviewed Apr 10, 2024

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Apr 10, 2024

AdrianoDee force-pushed the patch-9 branch from 69fc582 to 6235a6f Compare June 7, 2024 12:58

cmsbuild removed tests-approved code-checks-approved labels Jun 7, 2024

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jun 7, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 7, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 7, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 7, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 13, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 13, 2024

cmsbuild merged commit babb58f into cms-sw:master Jun 13, 2024
11 checks passed

This was referenced Jun 13, 2024

MTD geometry: fix BTL numbering scheme for scenario v3, input by Geant4, move unit tests to D110 scenario #45211

Merged

Heterogeneous Workflow (CLUE) in Phase2 HLT Simplified Menu #45178

Merged

AdrianoDee mentioned this pull request Jun 18, 2024

[14_0_X] Tunable PUMax in PrimaryVertexMonitor and Finer d_xy DQM Tracking Plots #45257

Merged

AdrianoDee deleted the patch-9 branch August 31, 2024 07:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tunable `PUMax` in `PrimaryVertexMonitor` and Finer d_xy DQM Tracking Plots #44669

Tunable `PUMax` in `PrimaryVertexMonitor` and Finer d_xy DQM Tracking Plots #44669

AdrianoDee commented Apr 9, 2024 •

edited

Loading

cmsbuild commented Apr 9, 2024 •

edited

Loading

cmsbuild commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

AdrianoDee commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

AdrianoDee commented Apr 10, 2024

mmusich Apr 10, 2024

AdrianoDee Apr 10, 2024

AdrianoDee Apr 10, 2024

tjavaid May 16, 2024

cmsbuild commented Apr 10, 2024

slava77 commented May 31, 2024

AdrianoDee commented Jun 4, 2024

AdrianoDee commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

tjavaid commented Jun 13, 2024

mmusich commented Jun 13, 2024

tjavaid commented Jun 13, 2024 •

edited

Loading

cmsbuild commented Jun 13, 2024

rappoccio commented Jun 13, 2024

	# same as above, should be in sync with cut used in Vertex finder...
	from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
	from Configuration.Eras.Modifier_run3_common_cff import run3_common
	from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker
	phase1Pixel.toModify(pvMonitor, EtaBin=28, EtaMin=-2.7, EtaMax=2.7)
	run3_common.toModify(pvMonitor, Xpos = 0.15, Ypos=-0.15) #recentering since initial Run3 beamspot is at (0.17,-0.18) cm
	phase2_tracker.toModify(pvMonitor, EtaBin=41, EtaBin2D=9, EtaMin=-4.0, EtaMax=4.0)

Tunable PUMax in PrimaryVertexMonitor and Finer d_xy DQM Tracking Plots #44669

Tunable PUMax in PrimaryVertexMonitor and Finer d_xy DQM Tracking Plots #44669

Conversation

AdrianoDee commented Apr 9, 2024 • edited Loading

cmsbuild commented Apr 9, 2024 • edited Loading

cmsbuild commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

AdrianoDee commented Apr 9, 2024

cmsbuild commented Apr 9, 2024

RelVals-INPUT

Comparison Summary

AdrianoDee commented Apr 10, 2024

mmusich Apr 10, 2024

Choose a reason for hiding this comment

AdrianoDee Apr 10, 2024

Choose a reason for hiding this comment

AdrianoDee Apr 10, 2024

Choose a reason for hiding this comment

tjavaid May 16, 2024

Choose a reason for hiding this comment

cmsbuild commented Apr 10, 2024

Comparison Summary

slava77 commented May 31, 2024

AdrianoDee commented Jun 4, 2024

AdrianoDee commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

Comparison Summary

tjavaid commented Jun 13, 2024

mmusich commented Jun 13, 2024

tjavaid commented Jun 13, 2024 • edited Loading

cmsbuild commented Jun 13, 2024

rappoccio commented Jun 13, 2024

Tunable `PUMax` in `PrimaryVertexMonitor` and Finer d_xy DQM Tracking Plots #44669

Tunable `PUMax` in `PrimaryVertexMonitor` and Finer d_xy DQM Tracking Plots #44669

AdrianoDee commented Apr 9, 2024 •

edited

Loading

cmsbuild commented Apr 9, 2024 •

edited

Loading

tjavaid commented Jun 13, 2024 •

edited

Loading