Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reco::displacedMuons to offline validation (backport) #44657

Merged

Conversation

24LopezR
Copy link
Contributor

@24LopezR 24LopezR commented Apr 8, 2024

PR description:

In this PR we add the code to include the reco::Muon displaced muon AOD collection to the Muon offline validation. An analyzer is added to Validation/RecoMuon/src, very similar to the one for standard muons. Also the necessary configuration files are added, and the sequences included in the global configuration.
Validation for standard muon collection is left unchanged.

See presentation on MUO POG General meeting: https://indico.cern.ch/event/1389920/#2-displaced-muon-in-the-valida

PR validation:

Same validation as in PR #44353. Basic tests (scram b runtests) have been run aswell.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of PR #44353 to release 14_0_X. The motivation for this backport is to have the code to validate the displacedMuon collection available in 14_0_X, meant for data taking during 2024.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

A new Pull Request was created by @24LopezR for CMSSW_14_0_X.

It involves the following packages:

  • Validation/RecoMuon (dqm)

@rvenditti, @cmsbuild, @antoniovagnerini, @tjavaid, @syuvivida, @nothingface0 can you please review it and eventually sign? Thanks.
@JanFSchulte, @trocino, @abbiendi, @calderona, @andrea21z, @jhgoh, @CeliaFernandez, @rociovilar, @HuguesBrun, @cericeci, @missirol, @Fedespring this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Apr 9, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bb39b/38695/summary.html
COMMIT: 59fba37
CMSSW: CMSSW_14_0_X_2024-04-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44657/38695/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 73 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3349032
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3349007
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 29848.476 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 2132.034 KiB Muons/RecoDisplacedMuonV
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

backport of #44353

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d918912 into cms-sw:CMSSW_14_0_X Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants