Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] New plugin for gen-part isolation. #44654

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

namapane
Copy link
Contributor

@namapane namapane commented Apr 8, 2024

PR description:

Backport of #44623.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

A new Pull Request was created by @namapane for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor

vlimant commented Apr 8, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Apr 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c10035/38676/summary.html
COMMIT: aed06fe
CMSSW: CMSSW_14_0_X_2024-04-07-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44654/38676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 99 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346242
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346205
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.84 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.115 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16470
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.61 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.115 KiB Physics/NanoAODDQM
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.575 2.553 0.021 ( +0.8% ) 5.19 5.12 +1.4% 2.224 2.241
2500.001 2.722 2.703 0.019 ( +0.7% ) 4.63 4.64 -0.2% 2.613 2.645
2500.002 2.668 2.643 0.024 ( +0.9% ) 4.75 4.83 -1.6% 2.643 2.633
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.44 9.56 -1.2% 2.261 2.283
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.15 5.18 -0.6% 2.435 2.431
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.40 7.29 +1.5% 2.318 2.422
2500.1 2.218 2.197 0.020 ( +0.9% ) 5.23 5.26 -0.5% 2.072 2.067
2500.2 2.333 2.314 0.019 ( +0.8% ) 5.94 5.83 +1.9% 1.985 1.985
2500.21 1.182 1.182 0.000 ( +0.0% ) 4.25 4.25 +0.1% 2.248 2.271
2500.211 1.546 1.546 0.000 ( +0.0% ) 3.73 3.70 +0.8% 2.345 2.354
2500.3 2.084 2.065 0.019 ( +0.9% ) 11.96 12.03 -0.6% 1.973 1.978
2500.301 2.660 2.637 0.023 ( +0.9% ) 10.19 9.49 +7.3% 1.959 1.959
2500.31 1.255 1.255 0.000 ( +0.0% ) 19.28 18.61 +3.6% 2.363 2.344
2500.311 1.641 1.641 0.000 ( +0.0% ) 13.41 12.87 +4.3% 2.437 2.415
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.37 1.43 -4.1% 1.692 1.700
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.76 6.64 +1.8% 1.050 1.058
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.71 13.79 -0.5% 2.236 2.178
2500.315 1.757 1.757 0.000 ( +0.0% ) 13.75 13.56 +1.4% 2.328 2.333
2500.316 3.093 3.093 0.000 ( +0.0% ) 2.20 2.21 -0.7% 1.977 2.276
2500.317 1.788 1.788 0.000 ( +0.0% ) 12.82 13.25 -3.2% 1.987 2.194
2500.4 2.243 2.226 0.017 ( +0.8% ) 11.74 11.65 +0.8% 1.855 1.857
2500.401 1.771 1.749 0.022 ( +1.3% ) 9.73 9.97 -2.4% 1.573 1.690
2500.402 2.792 2.770 0.022 ( +0.8% ) 9.47 9.76 -3.0% 1.751 1.913
2500.403 5.102 5.080 0.022 ( +0.4% ) 1.59 1.59 -0.5% 1.820 1.866
2500.404 2.800 2.778 0.022 ( +0.8% ) 9.58 9.38 +2.1% 1.754 1.702
2500.5 4.936 4.936 0.000 ( +0.0% ) 16.36 15.98 +2.4% 1.576 1.592
2500.51 8.960 8.960 0.000 ( +0.0% ) 9.89 9.83 +0.6% 1.533 1.537

@vlimant
Copy link
Contributor

vlimant commented Apr 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@vlimant
Copy link
Contributor

vlimant commented Apr 9, 2024

N.B : #44664 will popup unless we modify this PR

@vlimant
Copy link
Contributor

vlimant commented Apr 9, 2024

-xpog

@cmsbuild
Copy link
Contributor

Pull request #44654 was updated. @hqucms, @cmsbuild, @vlimant can you please check and sign again.

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

please test workflow 546.0,547.0,548.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c10035/38785/summary.html
COMMIT: 4ee621c
CMSSW: CMSSW_14_0_X_2024-04-11-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44654/38785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 922 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308451
  • DQMHistoTests: Total failures: 1355
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307076
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.84 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.115 KiB Physics/NanoAODDQM
  • Checked 210 log files, 173 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16470
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.61 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.115 KiB Physics/NanoAODDQM
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.575 2.553 0.021 ( +0.8% ) 5.17 5.22 -0.9% 2.234 2.219
2500.001 2.722 2.703 0.019 ( +0.7% ) 4.59 4.69 -2.1% 2.653 2.596
2500.002 2.668 2.643 0.024 ( +0.9% ) 4.77 4.87 -2.1% 2.630 2.596
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.43 9.69 -2.7% 2.347 2.296
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.19 5.24 -1.1% 2.544 2.459
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.35 7.46 -1.6% 2.450 2.374
2500.1 2.218 2.197 0.020 ( +0.9% ) 5.16 5.26 -1.9% 2.073 2.071
2500.2 2.333 2.314 0.019 ( +0.8% ) 5.90 6.01 -1.8% 1.986 1.983
2500.21 1.182 1.182 0.000 ( +0.0% ) 4.25 4.29 -0.9% 2.269 2.270
2500.211 1.546 1.546 0.000 ( +0.0% ) 3.65 3.75 -2.6% 2.345 2.357
2500.3 2.084 2.065 0.019 ( +0.9% ) 11.44 12.47 -8.2% 1.981 1.973
2500.301 2.660 2.637 0.023 ( +0.9% ) 9.47 10.20 -7.1% 1.956 1.957
2500.31 1.255 1.255 0.000 ( +0.0% ) 19.00 19.98 -4.9% 2.366 2.353
2500.311 1.641 1.641 0.000 ( +0.0% ) 13.03 13.36 -2.4% 2.438 2.453
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.41 1.34 +5.2% 1.695 1.698
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.66 6.50 +2.5% 1.050 1.050
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.61 13.95 -2.5% 2.182 2.151
2500.315 1.757 1.757 0.000 ( +0.0% ) 13.44 14.25 -5.7% 2.332 2.331
2500.316 3.093 3.093 0.000 ( +0.0% ) 2.18 2.24 -2.9% 2.278 2.273
2500.317 1.788 1.788 0.000 ( +0.0% ) 13.07 13.75 -5.0% 2.285 2.167
2500.4 2.243 2.226 0.017 ( +0.8% ) 11.43 12.14 -5.9% 1.898 1.883
2500.401 1.771 1.749 0.022 ( +1.3% ) 9.66 10.47 -7.7% 1.813 1.737
2500.402 2.792 2.770 0.022 ( +0.8% ) 9.64 10.16 -5.1% 1.873 1.786
2500.403 5.102 5.080 0.022 ( +0.4% ) 1.56 1.61 -2.9% 1.943 1.938
2500.404 2.800 2.778 0.022 ( +0.8% ) 9.22 9.95 -7.3% 1.864 1.902
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.30 15.98 -4.3% 1.721 1.627
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.67 9.69 -0.2% 1.658 1.660

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

+1

Failures for workflows 546.0,547.0,548.0 fixed by 4ee621c.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

Backport of #44623

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 050099f into cms-sw:CMSSW_14_0_X Apr 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants