Revert "Temporary: abort if cutParser fails to find methods"

[Dr15Jones]

Reverts #44590

The original PR is meant to be in the IBs temporarily as a debugging tool. Once we've decided the PR has served it's purpose, we want it reverted.

[Dr15Jones]

hold

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44620/39809

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• CommonTools/Utils (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

unhold

[Dr15Jones]

We think we've gathered enough data at this point and the failing unit test is now more of an annoyance than waiting to get more data.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b0620/38873/summary.html
COMMIT: 18a89b9
CMSSW: CMSSW_14_1_X_2024-04-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44620/38873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319475
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319455
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@cms-sw/reconstruction-l2 please sign as we no longer think this temporary debugging item is needed (and it is causing a unit test failure).

[makortel]

@cms-sw/reconstruction-l2 ping

[smuzaffar]

@cms-sw/orp-l2 , please bypass the signatures here. This PR reverts the temp abort @Dr15Jones added to catch the threading issue in ROOT (which is not needed any more). This should fix the failing IB unit test.

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1