Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Change unsubjet_map in btag info producers to tracked #44597

Merged

Conversation

stahlleiton
Copy link
Contributor

PR description:

backport of #44591

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @stahlleiton for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoBTag/FeatureTools (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@AlexDeMoor, @missirol, @andrzejnovak, @Senphy, @rovere, @JyothsnaKomaragiri, @emilbols, @AnnikaStein, @hqucms, @Martin-Grunewald, @silviodonato, @demuller, @Ming-Yan, @SohamBhattacharya this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

type btv

@cmsbuild cmsbuild added the btv label Apr 3, 2024
@mandrenguyen
Copy link
Contributor

backport of #44591

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

see please #44591 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

Pull request #44597 was updated. @mandrenguyen, @Martin-Grunewald, @cmsbuild, @jfernan2, @mmusich can you please check and sign again.

Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not super-important, but for book-keeping.

HLTrigger/Configuration/python/customizeHLTforCMSSW.py Outdated Show resolved Hide resolved
HLTrigger/Configuration/python/customizeHLTforCMSSW.py Outdated Show resolved Hide resolved
HLTrigger/Configuration/python/customizeHLTforCMSSW.py Outdated Show resolved Hide resolved
@stahlleiton stahlleiton force-pushed the UnsubjetMapTracked_CMSSW_14_0_X branch from 0220d3e to 1391d2f Compare April 3, 2024 08:39
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

Pull request #44597 was updated. @cmsbuild, @mmusich, @Martin-Grunewald, @mandrenguyen, @jfernan2 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d4b02/38568/summary.html
COMMIT: 1391d2f
CMSSW: CMSSW_14_0_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44597/38568/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Apr 4, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3aefebe into cms-sw:CMSSW_14_0_X Apr 4, 2024
10 checks passed
@stahlleiton stahlleiton deleted the UnsubjetMapTracked_CMSSW_14_0_X branch April 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants