-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slight update to TensorFlowAOT interface. #44586
Conversation
cms-bot internal usage |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44586/39753
|
A new Pull Request was created by @riga for master. It involves the following packages:
@wpmccormack, @valsdav, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c166d2/38549/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+ml |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description
This PR extends the TensorFlowAOT interface to simplify the configuration of dynamic batching rules (defining, e.g., how batch size X should be composed of batch sizes s1,s2,... that a model was compiled for; see this talk, slide 12) for plugins.
As batch rules could in principle be defined at execution time through options, a helper that converts strings such as
5:4,1
(i.e, run models for batch sizes 4 and 1 to compose batch size 5) to batch rules is required, which is provided by this PR.PR validation
The existing interface unit tests are updated to cover the conversion.
Should be tested with cms-sw/cmsdist#9108.