Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Backport of #44479 (Add number of B & C hadrons for GenJetAK8 and GenJet) to 14_0_X #44565

Conversation

nurfikri89
Copy link
Contributor

Backport of #44479

Original PR description:

This PR adds the number of B/C-hadrons branches for GenJetAK8 and GenJet tables . The same branches are removed from the FatJet table. Addresses the Issue here.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

A new Pull Request was created by @nurfikri89 for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor

vlimant commented Mar 28, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Mar 28, 2024

please test

@vlimant
Copy link
Contributor

vlimant commented Mar 28, 2024

I don’t think we absolutely needed this backtport to 14.0 at this time, but since you made it @nurfikri89 we might just as well do it

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0bbe8/38485/summary.html
COMMIT: a64fc6e
CMSSW: CMSSW_14_0_X_2024-03-27-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44565/38485/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 62 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346116
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346091
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.936 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16374
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16374
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.694 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.548 0.005 ( +0.2% ) 5.15 5.30 -2.7% 2.119 2.229
2500.001 2.703 2.698 0.005 ( +0.2% ) 4.62 4.73 -2.3% 2.514 2.643
2500.002 2.643 2.638 0.005 ( +0.2% ) 4.79 4.90 -2.3% 2.498 2.649
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.43 9.85 -4.3% 2.236 2.348
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.17 5.26 -1.6% 2.426 2.533
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.32 7.55 -3.1% 2.274 2.378
2500.1 2.196 2.192 0.005 ( +0.2% ) 5.27 5.32 -0.9% 1.950 2.069
2500.2 2.313 2.308 0.005 ( +0.2% ) 6.01 6.06 -0.8% 1.854 1.977
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.22 4.33 -2.4% 2.128 2.284
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.59 3.79 -5.3% 2.199 2.370
2500.3 2.062 2.058 0.005 ( +0.2% ) 12.32 12.76 -3.5% 1.899 1.969
2500.301 2.637 2.631 0.006 ( +0.2% ) 9.88 10.42 -5.2% 1.827 1.957
2500.31 1.254 1.254 0.000 ( +0.0% ) 19.37 20.15 -3.9% 2.238 2.367
2500.311 1.640 1.640 0.000 ( +0.0% ) 12.71 13.95 -8.9% 2.278 2.447
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.47 1.47 +0.0% 1.696 1.694
2500.313 1.564 1.564 0.000 ( +0.0% ) 7.15 6.96 +2.7% 1.046 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.53 14.96 -9.6% 2.035 2.218
2500.315 1.758 1.758 0.000 ( +0.0% ) 13.17 14.23 -7.5% 2.321 2.332
2500.4 2.062 2.058 0.005 ( +0.2% ) 12.20 12.63 -3.4% 1.819 1.888
2500.401 1.824 1.824 0.000 ( +0.0% ) 10.08 10.86 -7.2% 1.693 1.822
2500.402 2.637 2.631 0.006 ( +0.2% ) 9.57 10.22 -6.4% 1.876 1.820
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.24 1.29 -4.5% 1.145 1.275

@vlimant
Copy link
Contributor

vlimant commented Mar 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

hold

  • Since this is technically a data formats change and a new feature to the stable branch, this should be discussed at the ORP and needs sign-off from PPD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2024

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@antoniovilela
Copy link
Contributor

unhold

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5ae3c30 into cms-sw:CMSSW_14_0_X Apr 2, 2024
12 checks passed
@nurfikri89 nurfikri89 deleted the portFrom141XTo140X_nano_nHadronsInGenJets branch July 6, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants