-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport to 14_0_X (#44337)]: Add Veto Threshold to HCAL TP Emulator #44556
[Backport to 14_0_X (#44337)]: Add Veto Threshold to HCAL TP Emulator #44556
Conversation
A new Pull Request was created by @JHiltbrand for CMSSW_14_0_X. It involves the following packages:
@francescobrivio, @perrotta, @consuegs, @epalencia, @saumyaphor4252, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-421475/38455/summary.html Comparison SummarySummary:
|
+1
|
backport of #44373: |
+l1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
backport of #44373 |
+1 |
PR description:
As copied from #44373:
This PR incorporates a threshold for vetoing when applying the FIR filter during emulation of HCAL TP energy reconstruction in HB and HE. The veto threshold is taken from the
auxi2
field of theHcalTPChannelParameters
object for robust control of the veto threshold online and offline.Small change in logic is incurred at L519 of HcalTrigPrimAlgo, where check_sat is now only defined by saturation in BX0 or BX1.
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a backport of #44373 to target the 14_0_X release cycle.