Make PYTHIA 8 photon flux more configurable.

[hjbossi]

This PR is designed to make the process of incorporating the photon flux with Pythia 8 more configurable and, additionally, to allow the photon to be produced from either beam, as specified from the user. The output from the fragment does not change as a result of this PR (though the manner in which the user steers things does change - as updated in the fragment).

Verified that the new configuration runs with the photon being produced from either beam A or beam B (or both), that the default configurations for PbPb, OO, and XeXe work as expected, and that the user specifying new configurations also works.

Will need to prepare backports for release needed for MC production (13_0_X). Note that the current release is also fine for initial MC production, this PR just allows for additional user-set options.

@stahlleiton

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44549/39690

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @hjbossi for master.

It involves the following packages:

• Configuration/Generator (generators)
• GeneratorInterface/Pythia8Interface (generators)

@cmsbuild, @bbilin, @alberto-sanchez, @mkirsano, @SiewYan, @GurpreetSinghChahal, @menglu21 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @alberto-sanchez, @fabiocos, @mkirsano this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[stahlleiton]

After https://github.com/cms-sw/cmssw/blob/master/Configuration/Generator/python/Pythia8_GammaNucleus_5p36TeV_cfi.py is updated, this PR could be tested with relval workflow 180 and 181

[hjbossi]

After https://github.com/cms-sw/cmssw/blob/master/Configuration/Generator/python/Pythia8_GammaNucleus_5p36TeV_cfi.py is updated, this PR could be tested with relval workflow 180 and 181

@stahlleiton This is now added, this should be good to be tested with relval workflow 180 and 181

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44549/39711

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #44549 was updated. @alberto-sanchez, @SiewYan, @GurpreetSinghChahal, @cmsbuild, @mkirsano, @bbilin, @menglu21 can you please check and sign again.

[menglu21]

@cmsbuild please test

[menglu21]

@cmsbuild abort

[menglu21]

please test workflow 180,181

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dec8d/38716/summary.html
COMMIT: 5455ef6
CMSSW: CMSSW_14_1_X_2024-04-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44549/38716/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2500.3232500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

Comparison Summary

Summary:

• You potentially removed 18 lines from the logs
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3517457
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3517431
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 212 log files, 173 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[stahlleiton]

@menglu21 : I am not sure I understand the cause of the test failure. What does "Exception: config PhysicsTools/NanoAOD/nano_cff has no function nanoL1TrigObjCustomizeFull" has to do with this PR?

[menglu21]

@menglu21 : I am not sure I understand the cause of the test failure. What does "Exception: config PhysicsTools/NanoAOD/nano_cff has no function nanoL1TrigObjCustomizeFull" has to do with this PR?

Hi @stahlleiton could you please have a check on #44316, I'm not sure why there is "RAW2DIGI,NANO:@L1DPG" in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dec8d/38716/runTheMatrixINPUT-results/2500.323_l1DPGNANO130Xrun3/cmdLog

[stahlleiton]

@menglu21 : Seems this problem appears in most recent PR tests and is reported in #44666, so it is known and it is not related to this PR (or the one you pointed before)

[stahlleiton]

@menglu21 : seems most recent PR tests are working again, so please retrigger the tests again with workflow 180,181 , thanks

[menglu21]

please test workflow 180,181

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dec8d/38775/summary.html
COMMIT: 5455ef6
CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44549/38775/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 94 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3524833
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3524810
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 212 log files, 173 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[menglu21]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[antoniovilela]

@hjbossi
As a curiosity, does it also work with proton beams (one or both beams) ?
Many thanks.

[hjbossi]

Yes! It works with either one or both beams being proton beams! :)

[antoniovilela]

Yes! It works with either one or both beams being proton beams! :)

Many thanks!