Protection of hcalcalib DQM client when hltHcalCalibrationRaw is not found

[syuvivida]

PR description:

In the ECAL laser test runs, run 378496 and 378498, hcalcalib DQM clients crashed with the following error:
----- Begin Fatal Exception 26-Mar-2024 15:41:37 CET----------------------- An exception of category 'ProductNotFound' occurred while [0] Processing Event run: 378496 lumi: 1 event: 5835 stream: 0 [1] Running path 'p' [2] Calling method for module HcalRawToDigi/'hcalDigis' Exception Message: Principal::getByToken: Found zero products matching all criteria Looking for type: FEDRawDataCollection Looking for module label: hltHcalCalibrationRaw Looking for productInstanceName:

Previously in 13_0_X releases, SkipEvent was used to prevent this error. The protection was removed after moving to 14_X. This PR re-introduced the protection using TryToContinue.

PR validation:

A test has been done at the playback using the DQM streamers 378496. We were able to reproduce the crash using the current hcalcalib and removed the crash (skipping events) when using the code of this PR.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44545/39687

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @syuvivida for master.

It involves the following packages:

• DQM/Integration (dqm)

@nothingface0, @rvenditti, @syuvivida, @antoniovagnerini, @tjavaid, @cmsbuild can you please review it and eventually sign? Thanks.
@batinkov, @threus, @francescobrivio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[tjavaid]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e32c89/38432/summary.html
COMMIT: b06c49f
CMSSW: CMSSW_14_1_X_2024-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44545/38432/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation #44538
• @stahlleiton Disable workflow 180.1 #44540
• @jfernan2 [L1T] Fix for is not a valid DT id error #44417

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e32c89/38432/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e32c89/38432/git-merge-result

Comparison Summary

Summary:

• You potentially added 73 lines to the logs
• Reco comparison results: 52 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297857
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297831
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

type bug-fix

[antoniovilela]

+1