-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send full quality scale from uGMT to uGT [backport to 14_0_X] #44533
Send full quality scale from uGMT to uGT [backport to 14_0_X] #44533
Conversation
This is purely for bookkeeping, as the fakeParams aren't used normally.
A new Pull Request was created by @dinyar for CMSSW_14_0_X. It involves the following packages:
@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
Backport of #43888 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f251df/38389/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Is this a bug fix? If it is a new feature, this should not be backported to 14_0 without discussion in the ORP. |
Hi @rappoccio , this PR is essentially related to #44551 which was merged recently. I thought both of these PRs were discussed in ORP by @aloeliger and @epalencia . These are not required for data taking, but it will be good to have them in the release to fix DQM mismatches. |
@eyigitba Due to the readiness review and other schedule conflicts we haven't had time to discuss this in any ORP meetings. @rappoccio my understanding from @dinyar is that the firmware half of this change is online at P5, so this change is necessary in a data-taking release for emulator-firmware agreement. I can discuss this at the next ORP meeting if necessary. |
@cms-sw/l1-l2 |
+1 |
@antoniovilela My apologies. I wanted to make sure all signatures had been collected first and discuss with my partner to make sure one of us could be present/report at the next ORP meeting, but there's been multiple schedule conflicts with the L1T readiness review this past week. I think there's been a failure in communication on the L1T side. Let me discuss with him and then I can try to make the concurrent ORP meeting and L1T meeting in the future to prevent this. |
PR description:
From the 2024 running period uGMT will send the full quality scale instead of a truncated one to uGT. This PR implements this in the uGMT emulator.
Also updated the values of the matching windows for the ghost busting unit in the fakeParams. These parameters aren't used by the normal machinery, but only when overriding the standard workflows for studies.
PR validation:
Ran standard tests and compared with the firmware.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Need backport in order to be included in online DQM so we don't get data-emu mismatches (not sure who's responsible for this at the moment, tagging @jfernan2 speculatively).
Original at #43888