[CLANG_X] Use generated ctor in VertexProperty

[iarspider]

PR description:

This avoids Clang warning:

  <...>/CMSSW_14_1_CLANG_X_2024-03-24-2300/src/SimGeneral/MixingModule/interface/DecayGraph.h:69:3: warning: definition of implicit copy assignment operator for 'VertexProperty' is deprecated because it has a user-provided copy constructor [-Wdeprecated-copy-with-user-provided-copy]
    69 |   VertexProperty(const VertexProperty &other)
      |   ^

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW_14_1_CLANG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44530/39662

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• SimGeneral/MixingModule (simulation)

@mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ac734/38378/summary.html
COMMIT: e668c4e
CMSSW: CMSSW_14_1_CLANG_X_2024-03-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44530/38378/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11996 lines to the logs
• Reco comparison results: 31044 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 53954
• DQMHistoTests: Total nulls: 234
• DQMHistoTests: Total successes: 3243329
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
• DQMHistoSizes: changed ( 141.042,... ): 0.004 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[civanch]

@iarspider , I do not understand yet why we have huge number of differences. We likely need better understand the reason of usage of constructor removed in this PR. If it is not used why everything is different?

[makortel]

The comparisons are comparing clang build to gcc build

[makortel]

@cmsbuild, please test

Let's run default tests too

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ac734/38497/summary.html
COMMIT: e668c4e
CMSSW: CMSSW_14_1_X_2024-03-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44530/38497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 87 lines to the logs
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297437
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297411
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1