Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLANG_X] Use generated copy ctor in WeightsInfo #44529

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

This avoids Clang warning:

  <...>/CMSSW_14_1_CLANG_X_2024-03-24-2300/src/SimDataFormats/GeneratorProducts/interface/WeightsInfo.h:12:5: warning: definition of implicit copy assignment operator for 'WeightsInfo' is deprecated because it has a user-provided copy constructor [-Wdeprecated-copy-with-user-provided-copy]
    12 |     WeightsInfo(const WeightsInfo& o) : id(o.id), wgt(o.wgt) {}
      |     ^

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44529/39661

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • SimDataFormats/GeneratorProducts (generators)

@mkirsano, @menglu21, @alberto-sanchez, @bbilin, @GurpreetSinghChahal, @SiewYan can you please review it and eventually sign? Thanks.
@bsunanda, @rovere, @missirol, @apsallid, @fabiocos, @youyingli this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ad7bb/38377/summary.html
COMMIT: 01b5f82
CMSSW: CMSSW_14_1_CLANG_X_2024-03-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44529/38377/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11996 lines to the logs
  • Reco comparison results: 31051 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297537
  • DQMHistoTests: Total failures: 53959
  • DQMHistoTests: Total nulls: 234
  • DQMHistoTests: Total successes: 3243324
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): 0.004 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

please test

  • Let's get cleaner tests.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ad7bb/38467/summary.html
COMMIT: 01b5f82
CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44529/38467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ee44279 into cms-sw:master Mar 28, 2024
17 checks passed
@iarspider iarspider deleted the patch-4 branch April 2, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants